D15111: [KoUnit] Let's show pixel units

staniek added a comment. In D15111#317311 , @anthonyfieroni wrote: > @staniek did you want a DPI config spinbox? As in, e.g. GIMP, whenever we work in export-to-bitmap, and there's size other than in pixels, there's also DPI setting. Tha

D15102: Update deprecated QAbstractItemModel::reset() to use {begin, end}ResetModel() instead

piggz added a comment. @dcaliste by my count there are atleast 3 apps using kf5 libs now, calligra, my watch client app and my kdeconnect port. there has/to be scope for sharing effort :) ive just been shiping the libs in openrepos with the apps REPOSITORY R8 Calligra REVISION DETAIL h

D15102: Update deprecated QAbstractItemModel::reset() to use {begin, end}ResetModel() instead

dcaliste added a comment. @piggz thank you for the proposition. I've discussed with jpetrell, pvuorela and lbt on #sailfishos (see Tuesday 21th discussion, or the Tuesday before) and currently they prefer to have KF5 dependency packages within Calligra, not as standalone libraries in mer-cor

D15111: [KoUnit] Let's show pixel units

anthonyfieroni added a comment. @staniek did you want a DPI config spinbox? Can try this patch over master to approve it can be useful in Karbon? I keep in mind to make markers for SVG to have ability to save arrows, we have a bug report for that too. Maybe a little help will be needed :) R

D15102: Update deprecated QAbstractItemModel::reset() to use {begin, end}ResetModel() instead

piggz added a comment. nice, btw, i have a kf5 repo on the mer obs where i build kf5 libs for sailfish...perhaps that is easier for you? i use them in a few sfos apps, even kdb! my version is 5.31 atm is 5.34 the last version to build with qt5.6? i could never find the archives as they

D15111: [KoUnit] Let's show pixel units

staniek added a comment. In D15111#317263 , @boemann wrote: > we don't store pixel values but rather convert to points the user will not get pixel precise placement anyway Sure we but users who design for pixel size, like me, do that usin

D15111: [KoUnit] Let's show pixel units

boemann added a comment. And none of that contradicts me saying it's not a general feature we want, but at most for Karbon, and that since we don't store pixel values but rather convert to points the user will not get pixel precise placement anyway REPOSITORY R8 Calligra REVISION DETAIL

D15103: Replace deprecated use of QWeakPointer in favor of QPointer

boemann added a comment. I have no fundamentally against it, but I cannot test it right - so if it works 'm all for it REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15103 To: dcaliste, #calligra:_3.0, leinir, danders, boemann Cc: Calligra-Devel-list, cochise, vande

D15111: [KoUnit] Let's show pixel units

staniek added a comment. tl;dr images designed without regards to physical pixels size look well only for large sizes Are we talking about equivalent of this option of Inkscape? F6223325: image.png The Px unit has wide usage. In the bug des

D15111: [KoUnit] Let's show pixel units

boemann added a comment. discard as a general solution - it doesn't make close to any sense for other than karbon when used as a tool to generate pixmaps in the end, and even then as I said it's a bad idea for various reasons REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kd

D15111: [KoUnit] Let's show pixel units

anthonyfieroni added a comment. We'll rethink of being this option or i should discard as unwanted? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15111 To: anthonyfieroni, boemann, danders, #calligra:_3.0 Cc: Calligra-Devel-list, cochise, vandenoever

D15056: [EnhancedPathShape] Keep correct aspect ratio of shapes in odf files

This revision was automatically updated to reflect the committed changes. Closed by commit R8:da40d525d2c0: [EnhancedPathShape] Keep correct aspect ratio of shapes in odf files (authored by anthonyfieroni). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15056?v

D15103: Replace deprecated use of QWeakPointer in favor of QPointer

leinir added a reviewer: boemann. leinir added a comment. Adding in Camilla, because text :) REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15103 To: dcaliste, #calligra:_3.0, leinir, danders, boemann Cc: Calligra-Devel-list, cochise, vandenoever

D15102: Update deprecated QAbstractItemModel::reset() to use {begin, end}ResetModel() instead

leinir added a comment. In D15102#317181 , @dcaliste wrote: > @leinir, thank you. Instead of compiling with deprecation off, it's better to correct them ;) Absolutely yes ;) The CI does mark them, though, so that helps :) In

D15103: Replace deprecated use of QWeakPointer in favor of QPointer

dcaliste added reviewers: leinir, danders. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15103 To: dcaliste, #calligra:_3.0, leinir, danders Cc: Calligra-Devel-list, cochise, vandenoever

D15102: Update deprecated QAbstractItemModel::reset() to use {begin, end}ResetModel() instead

dcaliste added a comment. @leinir, thank you. Instead of compiling with deprecation off, it's better to correct them ;) I've finished making 3.1.0 compile in Sailfish SDK based on KF5 5.34.0 with minor tweaks, see http://git.merproject.org/dcaliste/calligra-bundle I'm commiting here al

D15102: Update deprecated QAbstractItemModel::reset() to use {begin, end}ResetModel() instead

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Entirely supported, wrapping things in begin/end model calls instead of just resetting is just... so much nicer in general :) And yes, deprecation warnings are nice to not have, so cool wit