D15053: Consistently use qreal in libs/pigment

2018-08-24 Thread Anthony Fieroni
anthonyfieroni added a comment. In D15053#314717 , @dcaliste wrote: > I cannot test easily on arm because karbon depends on KF5kdelibs4support, which is not available. I will investigate to remove it as depend. REPOSITORY R8 Calligra

D15056: [EnhancedPathShape] Keep correct aspect ratio of shapes in odf files

2018-08-24 Thread Anthony Fieroni
anthonyfieroni retitled this revision from "[EnhancedPathShape] Keep correct aspect ratio of odf files" to "[EnhancedPathShape] Keep correct aspect ratio of shapes in odf files". anthonyfieroni edited the test plan for this revision. REPOSITORY R8 Calligra REVISION DETAIL https://phabricato

D15053: Consistently use qreal in libs/pigment

2018-08-24 Thread Damien Caliste
dcaliste added a comment. After test (PRODUCTSET="KARBON"), it's not breaking karbon build on amd64. I cannot test easily on arm because karbon depends on KF5kdelibs4support, which is not available. But at least, proposed patch makes PART_WORDS and PART_STAGE compilable when qreal <=> fl

D15056: [EnhancedPathShape] Keep correct aspect ratio of odf files

2018-08-24 Thread Anthony Fieroni
anthonyfieroni updated this revision to Diff 40363. anthonyfieroni added a comment. Fix wrong diff REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15056?vs=40362&id=40363 REVISION DETAIL https://phabricator.kde.org/D15056 AFFECTED FILES plugins/pathshap

D15056: [EnhancedPathShape] Keep correct aspect ratio of odf files

2018-08-24 Thread Anthony Fieroni
anthonyfieroni created this revision. anthonyfieroni added reviewers: Calligra: 3.0, danders, boemann. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. anthonyfieroni requested review of this revision. REVISION SUMMARY View bound has same aspect ratio as con

D15053: Consistently use qreal in libs/pigment

2018-08-24 Thread Damien Caliste
dcaliste added a comment. Ok, I'll try in the afternoon or during the week-end and comment here. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15053 To: dcaliste, leinir, danders, #calligra:_3.0 Cc: anthonyfieroni, Calligra-Devel-list, cochise, vandenoever

D15053: Consistently use qreal in libs/pigment

2018-08-24 Thread Anthony Fieroni
anthonyfieroni added a comment. I'm OK with the patch, can you try Karbon as well? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15053 To: dcaliste, leinir, danders, #calligra:_3.0 Cc: anthonyfieroni, Calligra-Devel-list, cochise, vandenoever

D15053: Consistently use qreal in libs/pigment

2018-08-24 Thread Damien Caliste
dcaliste added a comment. I'm crosscompiling in SailfishOS SDK. I'm in the process of upgrading Calligra there to latest version. @leinir have done it earlier with version 2.9.x. At that moment, pigment was not containing that kind of function to change luminosity... where the conversions ar

D15053: Consistently use qreal in libs/pigment

2018-08-24 Thread Anthony Fieroni
anthonyfieroni added a comment. You use it on Pinebook or similar ARM based laptop? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15053 To: dcaliste, leinir, danders, #calligra:_3.0 Cc: anthonyfieroni, Calligra-Devel-list, cochise, vandenoever

D15053: Consistently use qreal in libs/pigment

2018-08-24 Thread Damien Caliste
dcaliste created this revision. dcaliste added reviewers: leinir, danders, Calligra: 3.0. dcaliste added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. dcaliste requested review of this revision. REVISION SUMMARY On my ARM environment, qreal is interpreted as float, no