D14916: [ArtisticTextShape] Merge text ranges with same style

2018-08-19 Thread Dag Andersen
danders added a comment. Hmm, I assumed it only got in here when appending a text to a) an empty shape (no need for merging), b) at the end of an existing text, in which case using the the existing formatting of the last range should ok. I just can't see why using a defaultfont in this ca

D14916: [ArtisticTextShape] Merge text ranges with same style

2018-08-19 Thread Anthony Fieroni
anthonyfieroni added a comment. Basically we want to be unchanged, but when it merged, now, it does not have guaranteed that appending to last will be nor same behavior nor correct. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D14916 To: anthonyfieroni, boemann, da

D14916: [ArtisticTextShape] Merge text ranges with same style

2018-08-19 Thread Dag Andersen
danders added a comment. The change in appendText(const QString &text): The original appended to an existing range while you add a new range. I would think you could just leave the old code untouched, no? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D14916 To: