D14916: [ArtisticTextShape] Merge text ranges with same style

2018-08-17 Thread Anthony Fieroni
anthonyfieroni created this revision. anthonyfieroni added reviewers: boemann, danders, Calligra: 3.0. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. anthonyfieroni requested review of this revision. REPOSITORY R8 Calligra REVISION DETAIL https://phabri

D14901: Fix blocklayout unittest after percentage lineheight was fixed in D9537

2018-08-17 Thread Dag Andersen
danders marked an inline comment as done. danders added a comment. What to change depends on what the number means ;) Well in general all numbers that depends on fontsize should be changed, the rest should stay the same, but yes it is a puzzle. REPOSITORY R8 Calligra REVISION DETAIL ht

D14901: Fix blocklayout unittest after percentage lineheight was fixed in D9537

2018-08-17 Thread Anthony Fieroni
anthonyfieroni added a comment. Thanks, i really don't know how to change predefined values like 28.0 etc. i see you changed them i still not clear to me what are the new vales :) INLINE COMMENTS > TestBlockLayout.cpp:497 > int lastLineNum = block1Layout->lineCount() - 1; > -const q

D14901: Fix blocklayout unittest after percentage lineheight was fixed in D9537

2018-08-17 Thread Dag Andersen
danders created this revision. danders added reviewers: boemann, anthonyfieroni. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. danders requested review of this revision. REVISION SUMMARY There is a couple of failing tests now marked as XFAIL. I am afrai