[Differential] [Commented On] D1032: Make KUndo2Stack::push return false if the command was merged (and deleted) rather than pushed

staniek added a comment. In https://phabricator.kde.org/D1032#23331, @aspotashev wrote: > Looks good to me. > > P.S. We probably need to share the kundo2 library between Kexi, Krita and Calligra. Thanks Alexander. Yes, this, or we would replace with Qt5 if there's equivalent

[Differential] [Closed] D1032: Make KUndo2Stack::push return false if the command was merged (and deleted) rather than pushed

This revision was automatically updated to reflect the committed changes. Closed by commit rCALLIGRA68ac8207a9cf: Make KUndo2Stack::push return false if the command was merged (and deleted)… (authored by staniek). REPOSITORY rCALLIGRA Calligra CHANGES SINCE LAST UPDATE https://phabricator.kd

Re: Review Request 127371: Support selections in Calligra ODT plugin for Okular (main textflow-only for now)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127371/ --- (Updated March 27, 2016, 7:34 p.m.) Status -- This change has been m

Re: Review Request 127371: Support selections in Calligra ODT plugin for Okular (main textflow-only for now)

> On March 18, 2016, 7:54 p.m., Camilla Boemann wrote: > > In general my reservations is the same as you explain - an entire method > > just to enable a plugin > > > > in theory it would be possible to use selectionRect but I conceede it would > > be really un-economical I so hoped you had a

[Differential] [Accepted] D1032: Make KUndo2Stack::push return false if the command was merged (and deleted) rather than pushed

aspotashev accepted this revision. aspotashev added a comment. This revision is now accepted and ready to land. Looks good to me. P.S. We probably need to share the kundo2 library between Kexi, Krita and Calligra. REPOSITORY rCALLIGRA Calligra BRANCH master REVISION DETAIL https