Jenkins-kde-ci: calligra master kf5-qt5 » Linux,All,gcc - Build # 170 - Still Unstable!

2015-10-02 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/calligra%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/170/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Sat, 03 Oct 2015 02:57:36 + Build duration: 1 hr 32 min CHANGE SET Revision 2221c3a42

Re: Review Request 125489: Cleanup KActionMenu usage: activated() is never emitted, member var not needed.

2015-10-02 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125489/#review86274 --- The patch breaks starting of the Presentation by pressing the

Jenkins-kde-ci: calligra calligra-2.9 stable-qt4 » Linux,All,gcc - Build # 281 - Still Unstable!

2015-10-02 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/calligra%20calligra-2.9%20stable-qt4/PLATFORM=Linux,Variation=All,compiler=gcc/281/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Sat, 03 Oct 2015 02:03:34 + Build duration: 1 hr 37 min CHANGE SET No change

Re: Review Request 125488: Avoid hitting assert in QPainter when CropWidget tries to paint a null image rect.

2015-10-02 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125488/#review86273 --- Ship it! Ship It! - Thorsten Zachmann On Oct. 2, 2015, 9:0

Re: Review Request 125490: Make Esc stop the presentation also in the main view.

2015-10-02 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125490/#review86272 --- Ship it! Ship It! - Thorsten Zachmann On Oct. 2, 2015, 9:1

Re: Review Request 125491: Fix crash when exiting Stage and the presentation mode is still on

2015-10-02 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125491/#review86271 --- Ship it! Ship It! - Thorsten Zachmann On Oct. 2, 2015, 9:1

Re: Review Request 125492: Remove AnimationTmpData struct, take two pointers for output values instead.

2015-10-02 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125492/#review86270 --- Ship it! Patch looks good. Please commit. Thanks for the patc

Re: Review Request 125494: PictureShapeConfigWidget: ensure we only select existing files.

2015-10-02 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125494/#review86269 --- Ship it! Looks good please commit. Thanks for the patch. Boud

Re: Review Request 125495: Fix empty animation steps when removing animations.

2015-10-02 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125495/#review86268 --- Ship it! Looks good please commit. Thanks for the patch. Boud

Jenkins-kde-ci: calligra calligra-2.9 stable-qt4 » Linux,All,gcc - Build # 280 - Still Unstable!

2015-10-02 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/calligra%20calligra-2.9%20stable-qt4/PLATFORM=Linux,Variation=All,compiler=gcc/280/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Fri, 02 Oct 2015 23:47:37 + Build duration: 1 hr 35 min CHANGE SET Revision

Jenkins-kde-ci: calligra calligra-2.9 stable-qt4 » Linux,All,gcc - Build # 279 - Still Unstable!

2015-10-02 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/calligra%20calligra-2.9%20stable-qt4/PLATFORM=Linux,Variation=All,compiler=gcc/279/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Fri, 02 Oct 2015 21:28:10 + Build duration: 1 hr 35 min CHANGE SET Revision

Re: Review Request 125486: Fix crash when typing a bogus color-set name in the color set dialog.

2015-10-02 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125486/ --- (Updated Oct. 2, 2015, 9:27 p.m.) Status -- This change has been mar

Review Request 125495: Fix empty animation steps when removing animations.

2015-10-02 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125495/ --- Review request for Calligra and Thorsten Zachmann. Repository: calligra

Review Request 125494: PictureShapeConfigWidget: ensure we only select existing files.

2015-10-02 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125494/ --- Review request for Calligra. Repository: calligra Description ---

Review Request 125493: PictureShapeConfigWidget: add error handling to KIO::Job.

2015-10-02 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125493/ --- Review request for Calligra. Repository: calligra Description ---

Review Request 125492: Remove AnimationTmpData struct, take two pointers for output values instead.

2015-10-02 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125492/ --- Review request for Calligra and Thorsten Zachmann. Repository: calligra

Review Request 125491: Fix crash when exiting Stage and the presentation mode is still on

2015-10-02 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125491/ --- Review request for Calligra and Thorsten Zachmann. Repository: calligra

Review Request 125490: Make Esc stop the presentation also in the main view.

2015-10-02 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125490/ --- Review request for Calligra. Repository: calligra Description ---

Review Request 125489: Cleanup KActionMenu usage: activated() is never emitted, member var not needed.

2015-10-02 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125489/ --- Review request for Calligra and Thorsten Zachmann. Repository: calligra

Review Request 125488: Avoid hitting assert in QPainter when CropWidget tries to paint a null image rect.

2015-10-02 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125488/ --- Review request for Calligra. Repository: calligra Description ---

Review Request 125487: Color set dialog: make combo non-editable, since typing a random name serves no purpose there.

2015-10-02 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125487/ --- Review request for Calligra and Thorsten Zachmann. Repository: calligra

Re: Review Request 125486: Fix crash when typing a bogus color-set name in the color set dialog.

2015-10-02 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125486/#review86253 --- Ship it! Please push, I'll merge to master and krita-next. -

Review Request 125486: Fix crash when typing a bogus color-set name in the color set dialog.

2015-10-02 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125486/ --- Review request for Calligra and Thorsten Zachmann. Repository: calligra

Review Request 125485: Unselect text when the text tool is deactivated.

2015-10-02 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125485/ --- Review request for Calligra and Thorsten Zachmann. Repository: calligra

Jenkins-kde-ci: calligra master kf5-qt5 » Linux,All,gcc - Build # 169 - Still Unstable!

2015-10-02 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/calligra%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/169/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Fri, 02 Oct 2015 11:48:53 + Build duration: 1 hr 42 min CHANGE SET Revision e1e21f936

Jenkins-kde-ci: calligra calligra-2.9 stable-qt4 » Linux,All,gcc - Build # 278 - Still Unstable!

2015-10-02 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/calligra%20calligra-2.9%20stable-qt4/PLATFORM=Linux,Variation=All,compiler=gcc/278/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Fri, 02 Oct 2015 10:01:08 + Build duration: 1 hr 36 min CHANGE SET Revision

Jenkins-kde-ci: calligra master kf5-qt5 » Linux,All,gcc - Build # 168 - Still Unstable!

2015-10-02 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/calligra%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/168/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Fri, 02 Oct 2015 07:48:37 + Build duration: 1 hr 36 min CHANGE SET Revision 254a936ca

Jenkins-kde-ci: calligra calligra-2.9 stable-qt4 » Linux,All,gcc - Build # 277 - Still Unstable!

2015-10-02 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/calligra%20calligra-2.9%20stable-qt4/PLATFORM=Linux,Variation=All,compiler=gcc/277/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Fri, 02 Oct 2015 07:37:57 + Build duration: 1 hr 34 min CHANGE SET Revision

Re: Many questions for Stage

2015-10-02 Thread Jos van den Oever
On 10/02/2015 10:53 AM, C. Boemann wrote: * I miss the "reopen on the page/slide where I was when closing the app" feature. I had code for that in KWord (and in the ODF specs) long ago... I can't really remember what it was though. Maybe something in meta.xml or so. it's not in Words either, but

Re: Many questions for Stage

2015-10-02 Thread C. Boemann
On Friday 02 October 2015 09:54:59 David Faure wrote: > Here are some questions to ensure I won't change behavior that was there on > purpose, or that I didn't miss something obvious: > > * Shape animations: Move up / Move down doesn't move the setting "start on > mouse click / start after previou

Re: Many fixes for Stage

2015-10-02 Thread Thorsten Zachmann
Hello David, On 2015-10-02 09:52, David Faure wrote: I used Stage to make a presentation yesterday, and I have many bugfixes to submit (and then some questions, and some bug reports). I just pushed the trivial fixes (typos and cleanups), but how do you want the patches for the more substantial

Re: Many fixes for Stage

2015-10-02 Thread Boudewijn Rempt
Pushed, also to master On Fri, 2 Oct 2015, Boudewijn Rempt wrote: On Fri, 2 Oct 2015, Boudewijn Rempt wrote: In addition: why did this commit to calligra/2.8 was never merged to calligra/2.9? http://osdir.com/ml/kde-commits/2014-09/msg00859.html Was I supposed to forwardport my commits rat

Re: Many fixes for Stage

2015-10-02 Thread Boudewijn Rempt
On Fri, 2 Oct 2015, Boudewijn Rempt wrote: In addition: why did this commit to calligra/2.8 was never merged to calligra/2.9? http://osdir.com/ml/kde-commits/2014-09/msg00859.html Was I supposed to forwardport my commits rather than relying on a regular git merge? Hm, I might have missed th

Re: Many fixes for Stage

2015-10-02 Thread Boudewijn Rempt
On Fri, 2 Oct 2015, David Faure wrote: I used Stage to make a presentation yesterday, and I have many bugfixes to submit (and then some questions, and some bug reports). I just pushed the trivial fixes (typos and cleanups), but how do you want the patches for the more substantial ones? Reviewb

Many questions for Stage

2015-10-02 Thread David Faure
Here are some questions to ensure I won't change behavior that was there on purpose, or that I didn't miss something obvious: * Shape animations: Move up / Move down doesn't move the setting "start on mouse click / start after previous animation / start after next animation". Shouldn't it? I ex

Many fixes for Stage

2015-10-02 Thread David Faure
I used Stage to make a presentation yesterday, and I have many bugfixes to submit (and then some questions, and some bug reports). I just pushed the trivial fixes (typos and cleanups), but how do you want the patches for the more substantial ones? Reviewboard? Phabricator? Patch on ML? Just push,