Re: What's new in KReport & KProperty & Predicate

2015-05-15 Thread Jaroslaw Staniek
On 15 May 2015, Adam Pigg wrote: > [23:09] jstaniek: tried example-piggz? Adam, I am sorry for delay. Yep, thanks, 'integration2' contains the code now. If your code is a little bit cleaner Please be more so I don't have to fix so much :) https://paste.kde.org/pgw50rw8k Now I recommend creati

Re: Review Request 123498: Fixes to KoReport maps plugin

2015-05-15 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123498/#review80447 --- Ship it! Let's integrate it into the example-piggz branch for

Re: Review Request 123498: Fixes to KoReport maps plugin

2015-05-15 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123498/#review80446 --- plugins/reporting/maps/KoReportItemMaps.h (line 96)

Re: Review Request 123764: Fix conflict between context menu and toggle action on icons in layers widget

2015-05-15 Thread Victor Wåhlström
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123764/ --- (Updated May 15, 2015, 2:23 p.m.) Status -- This change has been mar

Re: Review Request 123764: Fix conflict between context menu and toggle action on icons in layers widget

2015-05-15 Thread Boudewijn Rempt
> On May 13, 2015, 7:51 a.m., Boudewijn Rempt wrote: > > Thanks! As you said, we're sloppy checking for what particular mouse events > > mean, but I wonder though whether checking for QEvent::ContextMenu in bool > > KisDocumentSectionView::viewportEvent(QEvent *e) wouldn't help? > > Victor Wåh