Review Request 123764: Fix conflict between context menu and toggle action on icons in layers widget

2015-05-12 Thread Victor Wåhlström
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123764/ --- Review request for Calligra and Boudewijn Rempt. Bugs: 347541 http://

Re: What's new in KReport & KProperty & Predicate

2015-05-12 Thread Jaroslaw Staniek
Ok, @Adam please check the 'integration' branch: ASSERT failure in QList::operator[]: "index out of range", file /usr/include/qt5/QtCore/qlist.h, line 486 Aborted Compared to that, 93356498ab6eb works OK. On 12 May 2015 at 09:32, Jaroslaw Staniek wrote: > Update: > I think this week after some

Re: Review Request 123732: Replace obsolete QStyleOption::init()

2015-05-12 Thread Roman Shtemberko
> On Май 12, 2015, 1:42 п.п., Jarosław Staniek wrote: > > Cool find, I recommend fixing more of that; can be located +/- using: > > > > ack-grep -w "[a-z].init\([a-z ]" Thanks for the hint. - Roman --- This is an automatically generate

Re: Review Request 123732: Replace obsolete QStyleOption::init()

2015-05-12 Thread Roman Shtemberko
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123732/ --- (Updated Май 12, 2015, 3:28 п.п.) Review request for Calligra and Jarosła

Re: Review Request 123732: Replace obsolete QStyleOption::init()

2015-05-12 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123732/#review80235 --- Ship it! Cool find, I recommend fixing more of that; can be l

Review Request 123732: Replace obsolete QStyleOption::init()

2015-05-12 Thread Roman Shtemberko
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123732/ --- Review request for Calligra and Jarosław Staniek. Repository: calligra

Re: What's new in KReport & KProperty & Predicate

2015-05-12 Thread Jaroslaw Staniek
Update: I think this week after some cleanup of the commits and combining them where it makes sense, the work will come back to kreport.git! It will simplify the code review process. -- regards, Jaroslaw Staniek KDE: : A world-wide network of software engineers, artists, writers, translators :

Re: What's new in KReport & KProperty & Predicate

2015-05-12 Thread Jaroslaw Staniek
On 11 May 2015 at 20:54, Adam Pigg wrote: > doing this gets it compiling ... not sure if its The Right Thing > > kcoreaddons_desktop_to_json(KReport items/check/check.desktop) > kcoreaddons_desktop_to_json(KReport items/field/field.desktop) > kcoreaddons_desktop_to_json(KReport items/image/image.d