Re: Review Request 123471: Kexi: MapBrowser: Improved properties for forms and reports

2015-04-22 Thread Radosław Wicik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123471/ --- (Updated Kwi 23, 2015, 1:19 rano) Review request for Calligra, Andrius da

Re: Review Request 123432: Replace klocale.h with KLocalizedString

2015-04-22 Thread Kamil Łysik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123432/ --- (Updated Kwi 22, 2015, 11:11 po południu) Status -- This change has

Re: Review Request 123038: Development and porting of KProperty

2015-04-22 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123038/#review79366 --- Ok... please mark as submitted because it's in master already.

Re: Review Request 123471: Kexi: MapBrowser: Improved properties for forms and reports

2015-04-22 Thread Radosław Wicik
> On Kwi 22, 2015, 11:36 po południu, Jarosław Staniek wrote: > > kexi/plugins/forms/widgets/mapbrowser/MapBrowserWidget.cpp, line 37 > > > > > > Please explain in a comment here, why is remembering this values ne

Re: Review Request 123432: Replace klocale.h with KLocalizedString

2015-04-22 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123432/#review79365 --- Ship it! A good fix for now. I propose to convert the code to

Re: Review Request 123295: Kexi find dialog size improvements.

2015-04-22 Thread Roman Shtemberko
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123295/ --- (Updated April 22, 2015, 10:26 p.m.) Status -- This change has been

Re: Review Request 123357: Saving-as modified Kexi object does not remove its "dirty" flag

2015-04-22 Thread Roman Shtemberko
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123357/ --- (Updated April 22, 2015, 10:03 p.m.) Status -- This change has been

Re: Review Request 123471: Kexi: MapBrowser: Improved properties for forms and reports

2015-04-22 Thread Jarosław Staniek
> On April 22, 2015, 11:36 p.m., Jarosław Staniek wrote: > > plugins/reporting/maps/KoReportItemMaps.cpp, line 78 > > > > > > if you fix other i18n's, i18n("longitude") -> i18n("Longitude") is > > worth doing (I

Re: Review Request 123454: Changing wrong translation string for maps property.

2015-04-22 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123454/#review79358 --- Ship it! Good. PS: In KReport it's already fixed: 8923e4175e

Re: Review Request 123471: Kexi: MapBrowser: Improved properties for forms and reports

2015-04-22 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123471/#review79356 --- Cool! kexi/plugins/forms/widgets/mapbrowser/MapBrowserFactor

Review Request 123471: Kexi: MapBrowser: Improved properties for forms and reports

2015-04-22 Thread Radosław Wicik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123471/ --- Review request for Calligra, Andrius da Costa Ribas, Oleg Kukharchuk, Adam

Re: Review Request 123357: Saving-as modified Kexi object does not remove its "dirty" flag

2015-04-22 Thread Roman Shtemberko
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123357/ --- (Updated Апрель 22, 2015, 9:22 д.п.) Review request for Calligra, Adam Pi