Re: Re: Preview of astyle-kdelibs changes up in a branch (was: Re: [Port blocker] Re: [Kexi-devel] RFC: plan for starting the Qt5/KF5 port)

2015-03-05 Thread Dmitry Kazakov
Hi! I looked through the patch and updated the google docs: https://docs.google.com/document/d/1jhq6oXuXKvTilJhcoS6FVKO7yYRu2yCgBS9ojhc2QRU/edit# The changes which I believe we must fix before applying it to master: 1) Inlined functions. They are not covered by the KDE style policy, so I believe

Re: Proposal: standardized (subdir) names for 3rdparty/generated code

2015-03-05 Thread Elvis Stansvik
2015-03-06 1:16 GMT+01:00 Friedrich W. H. Kossebau : > Hi, > > so I spent quite some time scanning the sources, below is what I found as > TODO. > > So the idea still is: put 3rd-party code into a subdir "3rdparty" and put > generated and committed code into a subdir "generated", either locally or

Re: Re: Proposal: standardized (subdir) names for 3rdparty/generated code

2015-03-05 Thread C. Boemann
> filters/words/msword-odf/wv2 > from what I heard this can be considered a fork already. > but for now I would still treat it as 3rdparty lib, > until the further fate of this lib has been discussed > -> filters/words/msword-odf/3rdparty/wv2 it's very much a fork or rather a takeover and will rema

Re: Proposal: standardized (subdir) names for 3rdparty/generated code

2015-03-05 Thread Friedrich W. H. Kossebau
Hi, so I spent quite some time scanning the sources, below is what I found as TODO. So the idea still is: put 3rd-party code into a subdir "3rdparty" and put generated and committed code into a subdir "generated", either locally or globally. This allows automatted handling of such code files i

Re: RE: Does it ever load?

2015-03-05 Thread C. Boemann
I got the document and it loaded in 3 seconds - so don't really know what it was about On Thursday 05 March 2015 22:29:48 matus uzak wrote: > Hey, anything special about the document? Or a deadlock in the layout > engine? :) > > On Mar 4, 2015 3:04 PM, "C. Boemann" wrote: > > It probably doe

RE: Does it ever load?

2015-03-05 Thread matus uzak
Hey, anything special about the document? Or a deadlock in the layout engine? :) On Mar 4, 2015 3:04 PM, "C. Boemann" wrote: > It probably doesn't load if it has been stuck that long - feel free to > mail me the file privately if you want me to take a look and possibly fix it > > -Original M

Re: Proposal: standardized (subdir) names for 3rdparty/generated code

2015-03-05 Thread Friedrich W. H. Kossebau
Am Donnerstag, 5. März 2015, 17:22:53 schrieb Boudewijn Rempt: > Hi, > > You've got a good point... I think we need a list to start with. Yes. A start of the list would be all the things noted in the scratchpad about using astyle-kdelibs. Have not yet invested my little spare time in coming up

Re: Proposal: standardized (subdir) names for 3rdparty/generated code

2015-03-05 Thread Boudewijn Rempt
Hi, You've got a good point... I think we need a list to start with. One problem I already see is g'mic, which is 3rd party, but not a library and so is included directly in the g'mic plugin subtree. But I guess we could and should rename the directory it's in to 3rd party. On Thu, 5 Mar 201

Proposal: standardized (subdir) names for 3rdparty/generated code

2015-03-05 Thread Friedrich W. H. Kossebau
Hi, when looking through the complete repo for stuff that better is not touched by the planned automated astyle-based reformatting, two kinds of such files were seen: * copies of external sources * generated files Could we standardize something about those files, so they can be better handled

Re: Re: Preview of astyle-kdelibs changes up in a branch (was: Re: [Port blocker] Re: [Kexi-devel] RFC: plan for starting the Qt5/KF5 port)

2015-03-05 Thread Boudewijn Rempt
On Thu, 5 Mar 2015, C. Boemann wrote: As i already like the previous results this is just an improvement afaict. However, as a pure enhancement, do you know how difficult it would be to reformat all ctor initialize statements to be like: class::class() : super() , member(val) { I know