Re: Re: Preview of astyle-kdelibs changes up in a branch (was: Re: [Port blocker] Re: [Kexi-devel] RFC: plan for starting the Qt5/KF5 port)

2015-03-04 Thread C. Boemann
On Thursday 05 March 2015 02:56:11 Friedrich W. H. Kossebau wrote: > Am Mittwoch, 4. März 2015, 12:42:59 schrieb Boudewijn Rempt: > > Here's a scratchpad to note problems that might have to be solved: > > > > https://docs.google.com/document/d/1jhq6oXuXKvTilJhcoS6FVKO7yYRu2yCgBS9ojh > > c2 QRU/edi

Re: Re: Preview of astyle-kdelibs changes up in a branch (was: Re: [Port blocker] Re: [Kexi-devel] RFC: plan for starting the Qt5/KF5 port)

2015-03-04 Thread C. Boemann
On Thursday 05 March 2015 02:56:11 Friedrich W. H. Kossebau wrote: > * also patched with astyle_comma.diff (not part of provided spec.diff) so what does that patch do - what should we look for ___ calligra-devel mailing list calligra-devel@kde.org https:

Re: Preview of astyle-kdelibs changes up in a branch (was: Re: [Port blocker] Re: [Kexi-devel] RFC: plan for starting the Qt5/KF5 port)

2015-03-04 Thread Friedrich W. H. Kossebau
Am Mittwoch, 4. März 2015, 12:42:59 schrieb Boudewijn Rempt: > Here's a scratchpad to note problems that might have to be solved: > > https://docs.google.com/document/d/1jhq6oXuXKvTilJhcoS6FVKO7yYRu2yCgBS9ojhc2 > QRU/edit?usp=sharing And here another preview version, that * excludes more generat

Re: Review Request 122698: Kexi maps choosing Map Theme Id.

2015-03-04 Thread Radosław Wicik
> On Lut 24, 2015, 11:55 rano, Jarosław Staniek wrote: > > plugins/reporting/maps/MapRenderer.cpp, line 72 > > > > > > Why here and not in MapRenderer()? Some themes enable overview map after setting them up, thi

Re: Review Request 122698: Kexi maps choosing Map Theme Id.

2015-03-04 Thread Radosław Wicik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122698/ --- (Updated Mar 4, 2015, 11:44 po południu) Review request for Calligra, And

Re: Review Request 119368: Added shortcuts for performing actions on report's items in Kexi

2015-03-04 Thread Wojciech Kosowicz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119368/ --- (Updated March 4, 2015, 9:48 p.m.) Status -- This change has been ma

Re: Review Request 119368: Added shortcuts for performing actions on report's items in Kexi

2015-03-04 Thread Jarosław Staniek
> On March 3, 2015, 11:14 p.m., Jarosław Staniek wrote: > > kexi/plugins/reports/kexireportdesignview.cpp, line 170 > > > > > > This doesn't seem to be integrated with KDE settings. Maybe after Qt5 > > port? > >

Re: Review Request 119368: Added shortcuts for performing actions on report's items in Kexi

2015-03-04 Thread Wojciech Kosowicz
> On Mar 3, 2015, 10:14 po południu, Jarosław Staniek wrote: > > kexi/plugins/reports/kexireportdesignview.cpp, line 170 > > > > > > This doesn't seem to be integrated with KDE settings. Maybe after Qt5 > > port

Re: [Kexi-devel] Preview of astyle-kdelibs changes up in a branch (was: Re: [Port blocker] Re: RFC: plan for starting the Qt5/KF5 port)

2015-03-04 Thread Ben Cooksley
On Thu, Mar 5, 2015 at 12:56 AM, Jaroslaw Staniek wrote: > Nice thanks. > I see 28% of changes are non-whitespace. > Forcing {} for if/else is good. > > Could we please exclude dirs that contain forked code that would be > compared to external copies? > One comes to my mind: kexi/migration/mdb/src

Build failed in Jenkins: calligra_master » All,LINBUILDER #1365

2015-03-04 Thread KDE CI System
See Changes: [boud] Clean out forward includes [boud] Build fix -- [...truncated 9996 lines...] [ 52%] Built target calligra_shape_text [ 52%] Building CXX object kri

Re: Does it ever load?

2015-03-04 Thread Boudewijn Rempt
Sounds like a bug for that particular file. On Wed, 4 Mar 2015, John Culleton wrote: I am just starting with Calligra Word. I use Slackware Linux 14.1 which hasn't been updated in a while. I am trying to load a MSWord doc file that takes a long time to load into Libre Writer. But with Calligra

RE: Does it ever load?

2015-03-04 Thread C. Boemann
It probably doesn't load if it has been stuck that long - feel free to mail me the file privately if you want me to take a look and possibly fix it -Original Message- From: calligra-devel [mailto:calligra-devel-boun...@kde.org] On Behalf Of John Culleton Sent: Wednesday, March 4, 2015 13

Does it ever load?

2015-03-04 Thread John Culleton
I am just starting with Calligra Word. I use Slackware Linux 14.1 which hasn't been updated in a while. I am trying to load a MSWord doc file that takes a long time to load into Libre Writer. But with Calligra Word it seems to be an asymtotic function i.e. never quite getting there. I could eat bre

Build failed in Jenkins: calligra_master » All,LINBUILDER #1363

2015-03-04 Thread KDE CI System
See Changes: [dener.kup] Squashed commit of the following: -- [...truncated 11822 lines...] [ 76%] [ 76%] Built target ProjectTester [ 76%] Building CXX object sheets/

Re: [Kexi-devel] Preview of astyle-kdelibs changes up in a branch (was: Re: [Port blocker] Re: RFC: plan for starting the Qt5/KF5 port)

2015-03-04 Thread Boudewijn Rempt
Please directories that should be excluded to a list at https://docs.google.com/document/d/1jhq6oXuXKvTilJhcoS6FVKO7yYRu2yCgBS9ojhc2QRU/edit?usp=sharing On Wed, 4 Mar 2015, Jaroslaw Staniek wrote: Nice thanks. I see 28% of changes are non-whitespace. Forcing {} for if/else is good. Could we p

Re: [Kexi-devel] Preview of astyle-kdelibs changes up in a branch (was: Re: [Port blocker] Re: RFC: plan for starting the Qt5/KF5 port)

2015-03-04 Thread Jaroslaw Staniek
Nice thanks. I see 28% of changes are non-whitespace. Forcing {} for if/else is good. Could we please exclude dirs that contain forked code that would be compared to external copies? One comes to my mind: kexi/migration/mdb/src/mdbtools/. Anything else? For the future I'd use the tool as a local

Re: Preview of astyle-kdelibs changes up in a branch (was: Re: [Port blocker] Re: [Kexi-devel] RFC: plan for starting the Qt5/KF5 port)

2015-03-04 Thread Boudewijn Rempt
Here's a scratchpad to note problems that might have to be solved: https://docs.google.com/document/d/1jhq6oXuXKvTilJhcoS6FVKO7yYRu2yCgBS9ojhc2QRU/edit?usp=sharing On Wed, 4 Mar 2015, C. Boemann wrote: On Wednesday 04 March 2015 12:23:41 Friedrich W. H. Kossebau wrote: Am Mittwoch, 4. März

Re: Preview of astyle-kdelibs changes up in a branch (was: Re: [Port blocker] Re: [Kexi-devel] RFC: plan for starting the Qt5/KF5 port)

2015-03-04 Thread C. Boemann
On Wednesday 04 March 2015 12:23:41 Friedrich W. H. Kossebau wrote: > Am Mittwoch, 4. März 2015, 00:10:28 schrieb Friedrich W. H. Kossebau: > > Am Dienstag, 3. März 2015, 23:37:02 schrieb Jaroslaw Staniek: > > > First let's verify if astyle-kdelibs changes only whitespace. > > > > Okay, I propose

Preview of astyle-kdelibs changes up in a branch (was: Re: [Port blocker] Re: [Kexi-devel] RFC: plan for starting the Qt5/KF5 port)

2015-03-04 Thread Friedrich W. H. Kossebau
Am Mittwoch, 4. März 2015, 00:10:28 schrieb Friedrich W. H. Kossebau: > Am Dienstag, 3. März 2015, 23:37:02 schrieb Jaroslaw Staniek: > > First let's verify if astyle-kdelibs changes only whitespace. > > Okay, I propose that we wait with the porting start until this got sorted > out. > > No press

Re: [Port blocker] Re: [Kexi-devel] RFC: plan for starting the Qt5/KF5 port

2015-03-04 Thread Jaroslaw Staniek
On 4 March 2015 at 09:29, Boudewijn Rempt wrote: > On Wed, 4 Mar 2015, Jaroslaw Staniek wrote: > >> Extra remark: >> If we get used to call 'git blame ' where is the last >> revision before the 'formatting commit' would we be fine? > > > Yes, of course. That's what I'm doing all the time actually

Re: [Port blocker] Re: [Kexi-devel] RFC: plan for starting the Qt5/KF5 port

2015-03-04 Thread Boudewijn Rempt
On Wed, 4 Mar 2015, Jaroslaw Staniek wrote: Extra remark: If we get used to call 'git blame ' where is the last revision before the 'formatting commit' would we be fine? Yes, of course. That's what I'm doing all the time actually, since we already have a huge number of moments in our history

Re: [Port blocker] Re: [Kexi-devel] RFC: plan for starting the Qt5/KF5 port

2015-03-04 Thread Jaroslaw Staniek
Extra remark: If we get used to call 'git blame ' where is the last revision before the 'formatting commit' would we be fine? Or we can invent calligra-blame that ignores given commits ;) On 4 March 2015 at 00:10, Friedrich W. H. Kossebau wrote: > Am Dienstag, 3. März 2015, 23:37:02 schrieb Jaro

Re: RFC: plan for starting the Qt5/KF5 port

2015-03-04 Thread Boudewijn Rempt
On Tue, 3 Mar 2015, Friedrich W. H. Kossebau wrote: Other than that it seems to me no one now strongly rejects * astyle-kdelibs being applied to all of Calligra code * doing that in master * right before the port starts. Does this sounds like something that will make most people happy and least