Re: Review Request 122114: [OS X] adaptations of the build system (CMake files) to MacPorts

2015-02-09 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122114/ --- (Updated Feb. 9, 2015, 4:45 p.m.) Status -- This change has been mar

Re: Review Request 121800: Disable products which are not building/maintained on OSX globally

2015-02-09 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121800/ --- (Updated Feb. 9, 2015, 4:25 nachm.) Status -- This change has been d

Re: Review Request 122114: [OS X] adaptations of the build system (CMake files) to MacPorts

2015-02-09 Thread René J . V . Bertin
> On Feb. 9, 2015, 4:48 p.m., Friedrich W. H. Kossebau wrote: > > Looks good to me. Please commit. > > > > Good to see all those apps at least building on OSX :) Great you went > > through all the hassles to see what is possible. My pleasure, most of the effort was patience while things built

Re: Review Request 122114: [OS X] adaptations of the build system (CMake files) to MacPorts

2015-02-09 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122114/#review75700 --- Ship it! Looks good to me. Please commit. Good to see all th

Re: Review Request 122114: [OS X] adaptations of the build system (CMake files) to MacPorts

2015-02-09 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122114/ --- (Updated Feb. 9, 2015, 4:33 p.m.) Review request for Calligra and KDE Sof

Re: Review Request 122114: [OS X] adaptations of the build system (CMake files) to MacPorts

2015-02-09 Thread René J . V . Bertin
> On Jan. 20, 2015, 10:09 p.m., Friedrich W. H. Kossebau wrote: > > cmake/modules/FindOpenJPEG.cmake, line 32 > > > > > > Is this really needed? Does it not work without? > > > > From how I understood the

Re: Review Request 122197: Fixes to .ods import

2015-02-09 Thread Roman Shtemberko
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122197/ --- (Updated Фев. 9, 2015, 1:46 п.п.) Review request for Calligra and Jarosła

Re: Review Request 122197: Fixes to .ods import

2015-02-09 Thread Roman Shtemberko
> On Фев. 6, 2015, 11:47 п.п., Jarosław Staniek wrote: > > kexi/migration/AlterSchemaTableModel.cpp, line 28 > > > > > > 3 -> ROWS_FOR_PREVIEW you mean define new ROWS_FOR_PREVIEW in AlterSchemaTableModel.cpp, ri