Re: Review Request 121874: Improve major icons and introduce KexiIcon

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121874/ --- (Updated Jan. 8, 2015, 7:02 a.m.) Status -- This change has been mar

Re: Review Request 121874: Improve major icons and introduce KexiIcon

> On Jan. 8, 2015, 1:25 a.m., Friedrich W. H. Kossebau wrote: > > kexi/core/kexi.cpp, lines 42-43 > > > > > > Boud once for some reason I forgot (possible incomplete forward > > headers) standardized all kdelibs

Re: Review Request 121874: Improve major icons and introduce KexiIcon

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121874/#review73429 --- Ship it! Seems okay :) kexi/core/kexi.cpp

Re: Compiler warnings

On 7 January 2015 at 16:42, André Wöbbeking wrote: > Hi, > Thanks for letting us know! Fixed one in Kexi. Also pushed a "Replace obsolete QRect*::unite() with united()" fix, BTW. [..] > calligra/krita/image/krita_utils.cpp:131 This krita_utils.cpp:131 line looks like a bug: totalRect.

Re: Review Request 121793: Fix: if window gets focus back, view jumps to ensure current cell is visible

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121793/ --- (Updated Jan. 7, 2015, 10:15 p.m.) Status -- This change has been ma

Re: Review Request 121793: Fix: if window gets focus back, view jumps to ensure current cell is visible

> On Jan. 7, 2015, 10:09 p.m., Adam Pigg wrote: > > kexi/widget/dataviewcommon/kexidataawareobjectiface.h, line 325 > > > > > > its a bit of a mouthfull! Yes, tried hard to shorten it :) Maybe one day... - Jar

Re: Review Request 121886: Fix thumbnailing (for filemanager) by separate thumbnailer for Krita file types

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121886/ --- (Updated Jan. 7, 2015, 9:53 p.m.) Status -- This change has been mar

Re: Review Request 121886: Fix thumbnailing (for filemanager) by separate thumbnailer for Krita file types

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121886/#review73419 --- Ship it! Ship It! - Boudewijn Rempt On Jan. 7, 2015, 9:38

Re: Review Request 121886: Fix thumbnailing (for filemanager) by separate thumbnailer for Krita file types

> On Jan. 7, 2015, 9:12 vorm., Boudewijn Rempt wrote: > > Honestly, I'd say, don't bother with trying to render a krita or ora > > document if there's no thumbnail or merged image to use. > > > > ORA has: > > > > * Thumbnails/thumbnail.png > > * mergedimage.png > > > > KRA has: > > * preview

Re: Review Request 121886: Fix thumbnailing (for filemanager) by separate thumbnailer for Krita file types

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121886/ --- (Updated Jan. 7, 2015, 9:38 nachm.) Review request for Calligra and Boude

Re: Review Request 121793: Fix: if window gets focus back, view jumps to ensure current cell is visible

> On Jan. 7, 2015, 9:09 p.m., Adam Pigg wrote: > > Ship It! If you can think of another name, change it, if not then its ok - Adam --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121793/

Re: Review Request 121793: Fix: if window gets focus back, view jumps to ensure current cell is visible

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121793/#review73413 --- Ship it! Ship It! kexi/widget/dataviewcommon/kexidataawareo

Review Request 121902: Unset shortcuts for canvas actions that conflict with tool actions

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121902/ --- Review request for Calligra. Repository: calligra Description ---

Compiler warnings

Hi, compiling Calligra master with Clang I get some interesting warnings that should be fixed: warning: logical not is only applied to the left hand side of this comparison calligra/krita/plugins/formats/psd/psd_image_data.cpp:310 calligra/krita/plugins/formats/psd/psd_layer_record.cpp:718 call

Re: Review Request 121886: Fix thumbnailing (for filemanager) by separate thumbnailer for Krita file types

> On Jan. 7, 2015, 9:12 a.m., Boudewijn Rempt wrote: > > Honestly, I'd say, don't bother with trying to render a krita or ora > > document if there's no thumbnail or merged image to use. > > > > ORA has: > > > > * Thumbnails/thumbnail.png > > * mergedimage.png > > > > KRA has: > > * preview.

Re: Review Request 121886: Fix thumbnailing (for filemanager) by separate thumbnailer for Krita file types

> On Jan. 7, 2015, 9:13 vorm., Boudewijn Rempt wrote: > > I do agree with moving the kimgio plugins around, btw. Okay. Will move then around once this patch is in. - Friedrich W. H. --- This is an automatically generated e-mail. To repl

Re: Review Request 121886: Fix thumbnailing (for filemanager) by separate thumbnailer for Krita file types

> On Jan. 7, 2015, 9:12 vorm., Boudewijn Rempt wrote: > > Honestly, I'd say, don't bother with trying to render a krita or ora > > document if there's no thumbnail or merged image to use. > > > > ORA has: > > > > * Thumbnails/thumbnail.png > > * mergedimage.png > > > > KRA has: > > * preview

Re: Review Request 121886: Fix thumbnailing (for filemanager) by separate thumbnailer for Krita file types

> On Jan. 7, 2015, 9:12 a.m., Boudewijn Rempt wrote: > > Honestly, I'd say, don't bother with trying to render a krita or ora > > document if there's no thumbnail or merged image to use. > > > > ORA has: > > > > * Thumbnails/thumbnail.png > > * mergedimage.png > > > > KRA has: > > * preview.

Re: Review Request 121886: Fix thumbnailing (for filemanager) by separate thumbnailer for Krita file types

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121886/#review73336 --- I do agree with moving the kimgio plugins around, btw. - Boud

Re: Review Request 121886: Fix thumbnailing (for filemanager) by separate thumbnailer for Krita file types

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121886/#review73335 --- Honestly, I'd say, don't bother with trying to render a krita