Re: Review Request 121886: Fix thumbnailing (for filemanager) by separate thumbnailer for Krita file types

2015-01-06 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121886/ --- (Updated Jan. 6, 2015, 9:25 nachm.) Review request for Calligra and Boude

Re: Review Request 121886: Fix thumbnailing (for filemanager) by separate thumbnailer for Krita file types

2015-01-06 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121886/ --- (Updated Jan. 6, 2015, 7:06 nachm.) Review request for Calligra and Boude

Review Request 121886: Fix thumbnailing (for filemanager) by separate thumbnailer for Krita file types

2015-01-06 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121886/ --- Review request for Calligra and Boudewijn Rempt. Repository: calligra D

Re: crashing Qt through a QObject's dtor

2015-01-06 Thread René J . V . Bertin
On Tuesday January 06 2015 13:07:02 David Faure wrote: > It's wrong because it's fixing the symptom (null d pointer) instead of fixing > the cause (using an action that was already deleted). In an absolute sense you're right. But if this happens because of an API/runtime marriage that's (almost

Re: crashing Qt through a QObject's dtor

2015-01-06 Thread David Faure
On Tuesday 06 January 2015 12:35:01 René J.V. Bertin wrote: > On Tuesday January 06 2015 11:36:18 René J.V. Bertin wrote: > > And then the hackers' delight question: > > Staring at the code at almost 3am this morning it occurred to me that > > there is nothing wrong per se if QAction::isEnabled() r

Re: crashing Qt through a QObject's dtor

2015-01-06 Thread René J . V . Bertin
On Tuesday January 06 2015 11:36:18 René J.V. Bertin wrote: > And then the hackers' delight question: > Staring at the code at almost 3am this morning it occurred to me that there > is nothing wrong per se if QAction::isEnabled() returns false if the d > pointer is NULL (an invalid QAction canno