Review Request 121656: Krita - Fix weak shared pointer copy constructor and assignment

2014-12-23 Thread Stefano Bonicatti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121656/ --- Review request for Calligra. Repository: calligra Description ---

Re: Review Request 121598: Bug fix - 331483 : JJ Add "Flatten Layer" to the RightClick context menu

2014-12-23 Thread Sven Langkamp
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121598/#review72475 --- Excluding the transparency mask from flatten isn't needed as i

Review Request 121655: Add overloads (non-raw queries and params) for convenience KexiDB functions

2014-12-23 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121655/ --- Review request for Calligra, Andrius da Costa Ribas, Adam Pigg, Roman Shte

Re: Review Request 121598: Bug fix - 331483 : JJ Add "Flatten Layer" to the RightClick context menu

2014-12-23 Thread Rishabh Saxena
> On Dec. 21, 2014, 3:40 p.m., Boudewijn Rempt wrote: > > Hm -- check your editor's settings for whitespace changes. The only real > > change is in KisLayerBox (and that one is correct), but you have three > > files in your diff. Now, this has been fixed. :) - Rishabh -

Re: Review Request 121598: Bug fix - 331483 : JJ Add "Flatten Layer" to the RightClick context menu

2014-12-23 Thread Rishabh Saxena
> On Dec. 20, 2014, 7:40 a.m., Dmitry Kazakov wrote: > > Hi, Rishabh! > > > > Are you sure you want to put the Flatten Layer action into the same group > > with the actions that create new masks? I guess it would be more logical to > > put them into the same group with either Flatten Image or

Re: Review Request 121598: Bug fix - 331483 : JJ Add "Flatten Layer" to the RightClick context menu

2014-12-23 Thread Rishabh Saxena
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121598/ --- (Updated Dec. 23, 2014, 6:56 p.m.) Review request for Calligra and Boudew

Re: Review Request 120935: Add 'Value' property to report items which can contain static data if not bound to a field

2014-12-23 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120935/#review72462 --- Very good! Please update for the current calligra/2.9, there a