Re: Virtual functions causing link errors

2014-12-07 Thread Jaroslaw Staniek
Hi Patrik, Don't you mix Qt4 (calligra libs/headers/symbols) with a Qt5 code? On 8 December 2014 at 08:30, Patrik Gwét wrote: > I am struggling with an issue while I am using external .h files in my > project. > > I am using Qt5 with MSVC2012. In my main file, I am including a header > file from

Virtual functions causing link errors

2014-12-07 Thread Patrik Gwét
I am struggling with an issue while I am using external .h files in my project. I am using Qt5 with MSVC2012. In my main file, I am including a header file from a KDE application. I put some INCLUDEPATH in the .pro file to link correctly. The piece of code I am in trouble with is the following:

Re: Review Request 120898: Make side panes lighter by removing frames

2014-12-07 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120898/ --- (Updated Dec. 7, 2014, 10:37 p.m.) Status -- This change has been ma

Re: Review Request 120898: Make side panes lighter by removing frames

2014-12-07 Thread Adam Pigg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120898/#review71527 --- Ship it! Ship It! - Adam Pigg On Oct. 30, 2014, 2:54 p.m.,

Re: Review Request 120898: Make side panes lighter by removing frames

2014-12-07 Thread Jarosław Staniek
> On Oct. 30, 2014, 8:11 p.m., Adam Pigg wrote: > > What does it look like with a scroll bar? Where are the button actions > > gone from the top? > > Jarosław Staniek wrote: > http://wstaw.org/m/2014/10/30/plasma-desktopxB1834.png > > These are kept in the context menu. There will

Re: When to branch off 2.9 (was: Re: 2.8.7 and 2.9 release plan)

2014-12-07 Thread Jaroslaw Staniek
+1 PS: What would be the date for 2.9.0 stable? One big patch removing qt3support deps in Kexi - in tableview - is not yet put for review. It mostly works; no idea how long it would take to include it in 2.9 but I wouldn't like to have such big change mixed with Qt5 port... On 7 December 2014 at

Re: When to branch off 2.9 (was: Re: 2.8.7 and 2.9 release plan)

2014-12-07 Thread Cyrille Berger
On 2014-11-25 13:50, Cyrille Berger wrote: So I would suggest: * branch to 2.9 at beta 1 * freeze master, make it follow branch/2.9, we might even ask sysadmin to restrict pushing to master to calligra git admins (that would be Boudewijn and me) * do the port in a separate branch So what is the

Re: Review Request 120733: Pass more data between layout and RootAreaProvider

2014-12-07 Thread Pierre
On Saturday, December 06, 2014 07:11:04 PM Dan Leinir Turthra Jensen wrote: > This is, i know, somewhat late in the review phase, but i expect it's a > smallish issue anyway. In short, 4fa0b6e29d31d7755441b231ea3bf2ef068435b4 > breaks text input in Stage. Which i discovered while setting out to mak

Re: Review Request 121380: Krita - Fix some memory leaks.

2014-12-07 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121380/#review71513 --- Ship it! Thanks -- the only niggle is that if we manage to ge

Review Request 121380: Krita - Fix some memory leaks.

2014-12-07 Thread Stefano Bonicatti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121380/ --- Review request for Calligra. Repository: calligra Description ---

Re: Review Request 121226: Krita - Clean global origin workaround

2014-12-07 Thread Damien de Lemeny
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121226/ --- (Updated Dec. 7, 2014, 1:14 p.m.) Status -- This change has been mar