Re: Review Request 121281: When printing reports use High DPI

2014-11-30 Thread Adam Pigg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121281/ --- (Updated Nov. 30, 2014, 8:05 p.m.) Review request for Calligra and Jarosł

Virtual functions causing link errors

2014-11-30 Thread Patrik Gwét
I am struggling with an issue while I am using external .h files in my project. I am using Qt5 with MSVC2012. In my main file, I am including a header file from a KDE application. I put some INCLUDEPATH in the .pro file to link correctly. The piece of code I am in trouble with is the following:

Re: Review Request 119222: Make labels inline-editable

2014-11-30 Thread Jaroslaw Staniek
Yep, you're right, these changes are too heavy. On Sunday, 30 November 2014, Adam Pigg wrote: > This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119222/ > > On November 29th, 2014, 10:59 p.m. UTC, Jarosław Staniek wrote: > > Great job! > > We want it i

Re: Review Request 119222: Make labels inline-editable

2014-11-30 Thread Adam Pigg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119222/ --- (Updated Nov. 30, 2014, 8:48 a.m.) Status -- This change has been ma

Re: Review Request 119222: Make labels inline-editable

2014-11-30 Thread Adam Pigg
> On Nov. 29, 2014, 10:59 p.m., Jarosław Staniek wrote: > > Great job! > > > > We want it in 2.8 too... Is 2.8 not for bugfixes only? - Adam --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.o