Re: Review Request 120934: Fix Krita Gemini/Sketch window titles for filenames with %1 or %2 inside

2014-11-13 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120934/ --- (Updated Nov. 14, 2014, 12:01 a.m.) Status -- This change has been m

Setting up Qt Creator for building/running/debugging of Calligra apps

2014-11-13 Thread Jaroslaw Staniek
Hi, On request I've just updated a wiki page explaining how to set up Qt Creator for building/running/debugging of Calligra apps: https://community.kde.org/Calligra/Building/Developing_With_QtCreator It always seems that not everyone knows: using a good IDE is especially useful if you want to stu

Re: Review Request 120934: Fix Krita Gemini/Sketch window titles for filenames with %1 or %2 inside

2014-11-13 Thread Dan Leinir Turthra Jensen
> On Nov. 13, 2014, 7:36 p.m., Dan Leinir Turthra Jensen wrote: > > The KoDocument::modified(bool) signal needs to be sniffed. You deduced > > correctly that DocumentManager::documentChanged is when the actual document > > changes, not when the contents of the current document changes, but give

Re: Review Request 120934: Fix Krita Gemini/Sketch window titles for filenames with %1 or %2 inside

2014-11-13 Thread Dan Leinir Turthra Jensen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120934/#review70349 --- Ship it! Ship It! - Dan Leinir Turthra Jensen On Nov. 1, 2

Re: Review Request 120934: Fix Krita Gemini/Sketch window titles for filenames with %1 or %2 inside

2014-11-13 Thread Friedrich W. H. Kossebau
> On Nov. 13, 2014, 7:36 p.m., Dan Leinir Turthra Jensen wrote: > > The KoDocument::modified(bool) signal needs to be sniffed. You deduced > > correctly that DocumentManager::documentChanged is when the actual document > > changes, not when the contents of the current document changes, but give

Re: Review Request 120934: Fix Krita Gemini/Sketch window titles for filenames with %1 or %2 inside

2014-11-13 Thread Friedrich W. H. Kossebau
> On Nov. 13, 2014, 8:03 p.m., Boudewijn Rempt wrote: > > Hm, I'm sure I haven't thought through the entire problem but one thing > > stood out: with KF5's deprecation of kdialog, should we really add code > > that uses it? Yes, we should :) Because in Qt4 world KDialog is doing what only star

Re: Review Request 120934: Fix Krita Gemini/Sketch window titles for filenames with %1 or %2 inside

2014-11-13 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120934/#review70344 --- Hm, I'm sure I haven't thought through the entire problem but

Re: Review Request 120934: Fix Krita Gemini/Sketch window titles for filenames with %1 or %2 inside

2014-11-13 Thread Dan Leinir Turthra Jensen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120934/#review70340 --- The KoDocument::modified(bool) signal needs to be sniffed. You

Re: Review Request 119222: Make labels inline-editable

2014-11-13 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119222/#review70316 --- libs/koreport/items/label/BoundedTextItem.h