Re: Review Request 115512: added add text popup menu to calligra

2014-10-20 Thread Yue Liu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115512/ --- (Updated Oct. 21, 2014, 5:43 a.m.) Status -- This change has been di

Re: Review Request 120612: Krita: save settings for ellipse tool

2014-10-20 Thread Scott Petrovic
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120612/ --- (Updated Oct. 21, 2014, 3:51 a.m.) Review request for Calligra. Changes

Re: Review Request 120612: Krita: save settings for ellipse tool

2014-10-20 Thread Scott Petrovic
> On Oct. 19, 2014, 10:06 p.m., Sven Langkamp wrote: > > Another thing I noticed: When you have accidently saved with no fill and no > > outline, it appears that the tool stopped working and you wonder what > > happened. Maybe add a notification when that happens in the shape tools. > > Scott

Suggested Bug Fixes

2014-10-20 Thread Stephen Leibowitz
I am suggesting a number of fixes to Calligra. They are meant to address problems in its Windows builds as shown in the last entry here: http://www.winkde.org/pub/kde/ports/win32/dashboard/release/ Some of the fixes might also be helpful for non-Windows builds. As an aside, the Calligra version u

Re: GPL code in LGPL libs

2014-10-20 Thread Boudewijn Rempt
On Monday 20 October 2014 Oct 14:45:11 Jaroslaw Staniek wrote: > On 20 October 2014 14:07, Boudewijn Rempt wrote: > > On Monday 20 October > > 2014 Oct 08:05:24 Jaroslaw Staniek wrote: > >> The current list is at > >> https://community.kde.org/Calligra/Libs#License_cleanup > >> > > > > This is no

Re: GPL code in LGPL libs

2014-10-20 Thread Jaroslaw Staniek
On 20 October 2014 14:07, Boudewijn Rempt wrote: > On Monday 20 October > 2014 Oct 08:05:24 Jaroslaw Staniek wrote: >> The current list is at >> https://community.kde.org/Calligra/Libs#License_cleanup >> > > This is not a matter for a simple "clean-up" -- this is actually a serious > problem. >

Re: GPL code in LGPL libs

2014-10-20 Thread Boudewijn Rempt
On Monday 20 October 2014 Oct 14:07:32 Boudewijn Rempt wrote: > widgets/KoContextBarButton.cpp > widgets/KoContextBarButton.h > > These files actually don't seem to be used. I'll push their removal after I'm > done recompiling. > Oops, I'm wrong here. I guess my QtCreator config doesn't check s

Re: GPL code in LGPL libs

2014-10-20 Thread Boudewijn Rempt
On Monday 20 October 2014 Oct 08:05:24 Jaroslaw Staniek wrote: > The current list is at https://community.kde.org/Calligra/Libs#License_cleanup > This is not a matter for a simple "clean-up" -- this is actually a serious problem. These files come from digikam. We cannot simply relicense them: