Re: Review Request 120274: Add Qsort comparator (for Strings) which uses Collator.

2014-09-19 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120274/#review67015 --- Ship it! One fix left (include), then please push to 2.8 and

Re: Review Request 120274: Add Qsort comparator (for Strings) which uses Collator.

2014-09-19 Thread Jarosław Staniek
> On Sept. 19, 2014, 12:46 a.m., Jarosław Staniek wrote: > > libs/db/CMakeLists.txt, line 15 > > > > > > ${ICU_INCLUDE_DIRS} needed I guess like in libs/db/drivers/sqlite/icu > > > > The reason why it wor

Review Request 120294: Many fixes for Kexi database import assistant

2014-09-19 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120294/ --- Review request for Calligra, Andrius da Costa Ribas, Oleg Kukharchuk, Adam

Re: Review Request 120263: Add donations info to Kexi's status bar

2014-09-19 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120263/ --- (Updated Sept. 19, 2014, 11:49 p.m.) Status -- This change has been

Re: Review Request 120274: Add Qsort comparator (for Strings) which uses Collator.

2014-09-19 Thread Michal Poteralski
> On Sept. 18, 2014, 10:46 p.m., Jarosław Staniek wrote: > > libs/db/tableviewdata.cpp, line 156 > > > > > > - use kWarning() << ... > > - don't you want to return false here? I don't want return false becau

Re: Review Request 120274: Add Qsort comparator (for Strings) which uses Collator.

2014-09-19 Thread Michal Poteralski
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120274/ --- (Updated Sept. 19, 2014, 9:58 p.m.) Review request for Calligra, Andrius

Re: Review Request 120274: Add Qsort comparator (for Strings) which uses Collator.

2014-09-19 Thread Michal Poteralski
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120274/ --- (Updated Sept. 19, 2014, 9:56 p.m.) Review request for Calligra, Andrius

Re: Review Request 120274: Add Qsort comparator (for Strings) which uses Collator.

2014-09-19 Thread Michal Poteralski
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120274/ --- (Updated Sept. 19, 2014, 9:54 p.m.) Review request for Calligra, Andrius

Review Request 120291: cleaning up Advanced Colour Selector settings+Configurable HSY' luma.

2014-09-19 Thread Wolthera van Hövell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120291/ --- Review request for Calligra, Dmitry Kazakov, Sven Langkamp, and Boudewijn R

Review Request 120290: Proper background opacity handling and new background/foreground in kexi Reports items

2014-09-19 Thread Radosław Wicik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120290/ --- Review request for Calligra, Andrius da Costa Ribas, Oleg Kukharchuk, Adam

Re: Review Request 120263: Add donations info to Kexi's status bar

2014-09-19 Thread Adam Pigg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120263/#review66993 --- Ship it! Ship It! - Adam Pigg On Sept. 19, 2014, 8:19 p.m.

Re: Review Request 120263: Add donations info to Kexi's status bar

2014-09-19 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120263/ --- (Updated Sept. 19, 2014, 10:19 p.m.) Review request for Calligra, Andrius

Re: Review Request 120274: Add Qsort comparator (for Strings) which uses Collator.

2014-09-19 Thread Jarosław Staniek
> On Sept. 19, 2014, 12:46 a.m., Jarosław Staniek wrote: > > libs/db/tableviewdata.cpp, line 56 > > > > > > use K_GLOBAL_STATIC (from KGlobal) so the object gets destroyed on > > app's exit > > Michal Poteralski

Re: Review Request 120263: Add donations info to Kexi's status bar

2014-09-19 Thread Adam Pigg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120263/#review66985 --- kexi/main/startup/KexiWelcomeStatusBar.cpp

Re: Review Request 120274: Add Qsort comparator (for Strings) which uses Collator.

2014-09-19 Thread Michal Poteralski
> On Sept. 18, 2014, 10:46 p.m., Jarosław Staniek wrote: > > libs/db/tableviewdata.cpp, line 56 > > > > > > use K_GLOBAL_STATIC (from KGlobal) so the object gets destroyed on > > app's exit Collator is abstract

Re: Review Request 120263: Add donations info to Kexi's status bar

2014-09-19 Thread Wojciech Kosowicz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120263/#review66970 --- I build it. Got whitespace warning (informing). Looks good, it

Re: Review Request 119369: Item pasted in Kexi reports gets selected and pasted in the upper left corner or moved in relation to selection

2014-09-19 Thread Wojciech Kosowicz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119369/ --- (Updated Sept. 19, 2014, 1:04 p.m.) Status -- This change has been m

Re: Review Request 119369: Item pasted in Kexi reports gets selected and pasted in the upper left corner or moved in relation to selection

2014-09-19 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119369/#review66946 --- Ship it! Good job! One minor fix and please push! libs/kor

Re: Review Request 119369: Item pasted in Kexi reports gets selected and pasted in the upper left corner or moved in relation to selection

2014-09-19 Thread Wojciech Kosowicz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119369/ --- (Updated Sept. 19, 2014, 11:40 a.m.) Review request for Calligra and Adam