Re: Review Request 120128: [Kexi] Fix for regression in Reports

2014-09-10 Thread Jarosław Staniek
> On Sept. 10, 2014, 5:31 p.m., Adam Pigg wrote: > > libs/koreport/items/check/KoReportDesignerItemCheck.cpp, line 56 > > > > > > how about defining the names in a const somewhere? In master, similar need was ful

Re: Behaviour of KoServiceLocator

2014-09-10 Thread Adam Pigg
Ive tested the patch in relation to BUG: 338737, where the migratemanager is unable to load the postgresql driver, and this fixed it. (there are other bugs in the import, but thats not important here!) On Mon, Sep 8, 2014 at 5:50 PM, Jaroslaw Staniek wrote: > Hello, > I've been trying to figure

Re: Review Request 120128: [Kexi] Fix for regression in Reports

2014-09-10 Thread Adam Pigg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120128/#review66186 --- libs/koreport/items/check/KoReportDesignerItemCheck.cpp

Re: Review Request 120128: [Kexi] Fix for regression in Reports

2014-09-10 Thread Wojciech Kosowicz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120128/ --- (Updated Sept. 10, 2014, 2:33 p.m.) Review request for Calligra, Friedric

Re: Review Request 120128: [Kexi] Fix for regression in Reports

2014-09-10 Thread Jarosław Staniek
> On Sept. 10, 2014, 2:51 p.m., Jarosław Staniek wrote: > > libs/koreport/items/check/KoReportDesignerItemCheck.cpp, line 56 > > > > > > Yeah I was not sure if we should use the string literals here > > inste

Re: Review Request 120128: [Kexi] Fix for regression in Reports

2014-09-10 Thread Wojciech Kosowicz
> On Sept. 10, 2014, 12:51 p.m., Jarosław Staniek wrote: > > libs/koreport/items/check/KoReportDesignerItemCheck.cpp, line 56 > > > > > > Yeah I was not sure if we should use the string literals here > > inst

Re: Review Request 120128: [Kexi] Fix for regression in Reports

2014-09-10 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120128/#review66182 --- libs/koreport/items/check/KoReportDesignerItemCheck.cpp

Re: Review Request 120128: [Kexi] Fix for regression in Reports

2014-09-10 Thread Adam Pigg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120128/#review66181 --- libs/koreport/items/check/KoReportDesignerItemCheck.cpp

Review Request 120128: [Kexi] Fix for regression in Reports

2014-09-10 Thread Wojciech Kosowicz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120128/ --- Review request for Calligra, Friedrich W. H. Kossebau, Adam Pigg, and Jaros