Re: Why to redirect to https for calligra.org?

2014-07-27 Thread Ben Cooksley
On 28 July 2014 09:08, Jaroslaw Staniek wrote: > Hi, Hi Jaroslaw, > Probably picky question to Cyrille but CC'd Ben to be safe. > Asking because I'd like to see browsers to show calligra.org as a trusted > site. > > It's almost perfect but I see redirection to https://calligra.org from > http:/

Why to redirect to https for calligra.org?

2014-07-27 Thread Jaroslaw Staniek
Hi, Probably picky question to Cyrille but CC'd Ben to be safe. Asking because I'd like to see browsers to show calligra.org as a trusted site. It's almost perfect but I see redirection to https://calligra.org from http://www.calligra.org in my browsers. So far so good but Firefox nicely explains

Re: Review Request 119502: Use unset(..) instead of set(..) to unset CMake variables

2014-07-27 Thread Elvis Stansvik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119502/ --- (Updated July 27, 2014, 5:49 p.m.) Review request for Calligra and Friedr

Re: Review Request 119496: Log explicitely why a product was dropped

2014-07-27 Thread Elvis Stansvik
> On July 27, 2014, 4:10 p.m., Elvis Stansvik wrote: > > cmake/modules/CalligraProductSetMacros.cmake, line 37 > > > > > > is this necessary? it just unsets ${_current_flag} right? (which has > > never been set a

Review Request 119502: Use unset(..) instead of set(..) to unset CMake variables

2014-07-27 Thread Elvis Stansvik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119502/ --- Review request for Calligra and Friedrich W. H. Kossebau. Repository: cal

Re: Review Request 119496: Log explicitely why a product was dropped

2014-07-27 Thread Friedrich W. H. Kossebau
> On Juli 27, 2014, 4:10 nachm., Elvis Stansvik wrote: > > cmake/modules/CalligraProductSetMacros.cmake, line 43 > > > > > > maybe use unset(..) instead? it's a little clearer i think. at least i > > had to consu

Re: Review Request 119496: Log explicitely why a product was dropped

2014-07-27 Thread Elvis Stansvik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119496/#review63263 --- cmake/modules/CalligraProductSetMacros.cmake

Re: Review Request 119496: Log explicitely why a product was dropped

2014-07-27 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119496/ --- (Updated July 27, 2014, 3:55 p.m.) Status -- This change has been ma

Re: Review Request 119496: Log explicitely why a product was dropped

2014-07-27 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119496/#review63244 --- Ship it! I'd call it "calligra_drop_product_on_missing_depend