Re: Review Request 119222: Make labels inline-editable

2014-07-13 Thread Friedrich W. H. Kossebau
> On Juli 13, 2014, 6:45 nachm., Kamil Łysik wrote: > > libs/koreport/items/label/KoReportDesignerItemLabel.cpp, line 193 > > > > > > I got build error: adding > > #include > > fixed this. Is this inclu

Re: Review Request 119222: Make labels inline-editable

2014-07-13 Thread Kamil Łysik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119222/#review62258 --- libs/koreport/items/label/KoReportDesignerItemLabel.cpp

Re: How to fix import of headings in DOC/DOCX (text:h instead of text:p)?

2014-07-13 Thread Lassi Nieminen
Docx the magical file is DocxXmlDocumentReader.cpp (don't have code atm., so method names may be slightly different) For style the structure seems to be: In read_pPr you need to add a call to new method read_outlineLvl where you can read the potential value In the actual document in w:pPr yo

Re: Review Request 119244: _C symbol breaks compilation on OpenBSD

2014-07-13 Thread Boudewijn Rempt
> On July 13, 2014, 8:49 a.m., Boudewijn Rempt wrote: > > Wow... This must mean that nobody has compiled Krita on OpenBSD since > > September 2010 :-). > > Vadim Zhukov wrote: > I did - many times, but I was too lazy to send patches, sorry. Now that > Calligra and many other modern KDE stu

Re: Review Request 119244: _C symbol breaks compilation on OpenBSD

2014-07-13 Thread Vadim Zhukov
> On Июль 13, 2014, 12:49 п.п., Boudewijn Rempt wrote: > > Wow... This must mean that nobody has compiled Krita on OpenBSD since > > September 2010 :-). I did - many times, but I was too lazy to send patches, sorry. Now that Calligra and many other modern KDE stuff got into official OpenBSD Po

Re: Review Request 119244: _C symbol breaks compilation on OpenBSD

2014-07-13 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119244/#review62235 --- Ship it! Wow... This must mean that nobody has compiled Krita

Re: Review Request 119244: _C symbol breaks compilation on OpenBSD

2014-07-13 Thread Vadim Zhukov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119244/ --- (Updated July 13, 2014, 8:48 a.m.) Status -- This change has been ma

Re: Review Request 119244: _C symbol breaks compilation on OpenBSD

2014-07-13 Thread Dmitry Kazakov
> On Июль 13, 2014, 8:40 д.п., Dmitry Kazakov wrote: > > Hi, Vadim! > > > > Thanks for a nice catch! Can you push the patch into master or we should do > > it on bahalf you you? Oh, I read till the end. I'll push it now. - Dmitry ---

Re: Review Request 119244: _C symbol breaks compilation on OpenBSD

2014-07-13 Thread Dmitry Kazakov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119244/#review62232 --- Ship it! Hi, Vadim! Thanks for a nice catch! Can you push th