Re: Review Request 119075: Added printing reports to pdf feature in Kexi

2014-07-08 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119075/#review61942 --- kexi/plugins/reports/kexireportview.cpp

Re: Review Request 119075: Added printing reports to pdf feature in Kexi

2014-07-08 Thread Wojciech Kosowicz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119075/ --- (Updated Lip 8, 2014, 10:23 po południu) Review request for Calligra and

Re: Review Request 119075: Added printing reports to pdf feature in Kexi

2014-07-08 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119075/#review61941 --- Please also change branch in this review to master. - Jarosła

Re: Review Request 119075: Added printing reports to pdf feature in Kexi

2014-07-08 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119075/#review61940 --- Please add bug 335150 to this review. - Jarosław Staniek On

Re: Review Request 119075: Added printing reports to pdf feature in Kexi

2014-07-08 Thread Wojciech Kosowicz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119075/ --- (Updated Lip 8, 2014, 9:55 po południu) Review request for Calligra and J

Re: Review Request 119075: Added printing reports to pdf feature in Kexi

2014-07-08 Thread Wojciech Kosowicz
> On Lip 7, 2014, 11:16 po południu, Jarosław Staniek wrote: > > kexi/plugins/reports/kexireportview.cpp, line 211 > > > > > > Add KUrl arg to getExportUrl() and fill it everywhere. This will fix > > missing d

Re: Review Request 119075: Added printing reports to pdf feature in Kexi

2014-07-08 Thread Wojciech Kosowicz
> On Lip 7, 2014, 11:16 po południu, Jarosław Staniek wrote: > > kexi/plugins/reports/kexireportview.cpp, line 135 > > > > > > why this differs compared to previous message? > > Wojciech Kosowicz wrote: >

Re: Review Request 119075: Added printing reports to pdf feature in Kexi

2014-07-08 Thread Wojciech Kosowicz
> On Lip 7, 2014, 11:16 po południu, Jarosław Staniek wrote: > > kexi/plugins/reports/kexireportview.cpp, line 134 > > > > > > why this differs compared to previous message? I wanted to make it unified with ot

Re: Review Request 119033: Replace KServiceTypeTrader with KoServiceLocator

2014-07-08 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119033/ --- (Updated July 8, 2014, 4:03 p.m.) Status -- This change has been mar

Re: Review Request 119033: Replace KServiceTypeTrader with KoServiceLocator

2014-07-08 Thread Sven Langkamp
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119033/#review61908 --- Ship it! Tested it with Krita and Karbon and it works good. N

Re: Review Request 119033: Replace KServiceTypeTrader with KoServiceLocator

2014-07-08 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119033/ --- (Updated July 8, 2014, 8:22 a.m.) Review request for Calligra. Changes

Notes from the 2014 Sprint Meeting

2014-07-08 Thread Boudewijn Rempt
* Repository splitting, social consequences of splitting up -> Problems: we have libraries that are tangled together and that are packaged together in distributions, so Krita depends on sqlite, even. Our libraries depend on QtWidget, which makes mobile apps harder to make, and mobile is where C