Review Request 118510: small rework of product sets: products, features and product sets

2014-06-03 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118510/ --- Review request for Calligra, Yue Liu, Boudewijn Rempt, and Jarosław Staniek

Re: [kexi] [Bug 334093] Names of newly added tables and queries not properly sorted in forms data source combo

2014-06-03 Thread Jaroslaw Staniek
Wojciech, Nice, just one minor remark. The commit message should better mention the summary of the bug in the 1st line, i.e. "Properly sort newly added tables and queries in forms data source combo" And primarily, it should explain *why* it exists, *not* what is being done. Always think about com

Re: Review Request 118485: [kexi] changed call addItem to insertItem in slot of KexiDataSourceComboBox so items have correct order

2014-06-03 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118485/#review59113 --- This review has been submitted with commit 5a4e7a9e04273635cd

Re: Review Request 118485: [kexi] changed call addItem to insertItem in slot of KexiDataSourceComboBox so items have correct order

2014-06-03 Thread Wojciech Kosowicz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118485/ --- (Updated June 3, 2014, 9:29 p.m.) Status -- This change has been mar

Re: Review Request 118485: [kexi] changed call addItem to insertItem in slot of KexiDataSourceComboBox so items have correct order

2014-06-03 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118485/#review59112 --- This review has been submitted with commit f3949bc88b3a326698

Re: Review Request 118485: [kexi] changed call addItem to insertItem in slot of KexiDataSourceComboBox so items have correct order

2014-06-03 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118485/#review59110 --- Ship it! Ship It! - Jarosław Staniek On June 3, 2014, 9:09

Re: Review Request 118485: [kexi] changed call addItem to insertItem in slot of KexiDataSourceComboBox so items have correct order

2014-06-03 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118485/#review59109 --- Congratz! Please push to calligra/2.8 and master. - Jarosław

Re: Review Request 118485: [kexi] changed call addItem to insertItem in slot of KexiDataSourceComboBox so items have correct order

2014-06-03 Thread Wojciech Kosowicz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118485/ --- (Updated June 3, 2014, 9:09 p.m.) Review request for Calligra and Jarosła

Build failed in Jenkins: calligra_master » All,LINBUILDER #553

2014-06-03 Thread KDE CI System
See Changes: [dimula73] Hide Pseudo Infinite canvas decoration when in Wraparound mode -- Started by upstream project "calligra_master" build number 553 originally cause