Re: Review Request 117803: Update list of reserved keywords for sqlite in Kexi

2014-05-01 Thread Wojciech Kosowicz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117803/ --- (Updated May 1, 2014, 11:46 p.m.) Status -- This change has been mar

Re: Review Request 117803: Update list of reserved keywords for sqlite in Kexi

2014-05-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117803/#review57091 --- This review has been submitted with commit de07f92717012158b8

Re: Review Request 117803: Update list of reserved keywords for sqlite in Kexi

2014-05-01 Thread Wojciech Kosowicz
> On May 1, 2014, 10:53 p.m., Jarosław Staniek wrote: > > Good catch, Wojtek! > > > > As we can see StaticSetOfStrings is used for optimization (it offers zero > > mem copy). > > > > Summing up, I think 5 separate commits would be ideal: > > 1, 2, 3: update the lists of keywords (for 3 db eng

Re: Review Request 117803: Update list of reserved keywords for sqlite in Kexi

2014-05-01 Thread Wojciech Kosowicz
> On May 1, 2014, 10:53 p.m., Jarosław Staniek wrote: > > Good catch, Wojtek! > > > > As we can see StaticSetOfStrings is used for optimization (it offers zero > > mem copy). > > > > Summing up, I think 5 separate commits would be ideal: > > 1, 2, 3: update the lists of keywords (for 3 db eng

Re: Review Request 117803: Update list of reserved keywords for sqlite in Kexi

2014-05-01 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117803/#review57087 --- Good catch, Wojtek! As we can see StaticSetOfStrings is used

Re: Review Request 117803: Update list of reserved keywords for sqlite in Kexi

2014-05-01 Thread Wojciech Kosowicz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117803/ --- (Updated May 1, 2014, 10:40 p.m.) Review request for Calligra and Jarosła

Re: Review Request 117937: Remove hardcoded margins from Krita filter dialog, use normal buttonbox for ok/cancel

2014-05-01 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117937/ --- (Updated May 1, 2014, 10:36 p.m.) Review request for Calligra and Boudewi

Re: Review Request 117803: Update list of reserved keywords for sqlite in Kexi

2014-05-01 Thread Wojciech Kosowicz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117803/ --- (Updated May 1, 2014, 10:33 p.m.) Review request for Calligra and Jarosła

Review Request 117937: Remove hardcoded margins from Krita filter dialog, use normal buttonbox for ok/cancel

2014-05-01 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117937/ --- Review request for Calligra and Boudewijn Rempt. Repository: calligra D

Re: Reading Odb files

2014-05-01 Thread Jaroslaw Staniek
Hello Harshita, Update: added a wiki page dedicated to this development: http://community.kde.org/Kexi/Junior_Jobs/Add_support_for_importing_tables_from_LibreOffice_Base Please use it to store any documents. PS: Sid you manage to publish actual source code in an external git repo (github, gitorio

Re: Review Request 117797: Fix for Kexi crash in DebugGUI mode

2014-05-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117797/#review57060 --- This review has been submitted with commit 4d9b8e574cbee5d1fe