Re: Review Request 116816: Small patches for building on Mac OS X against KDE

2014-03-23 Thread Yue Liu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116816/#review53870 --- do you still have the gmic clang issue? - Yue Liu On March

Re: Review Request 116949: close all tabs command added

2014-03-23 Thread Vishwa Modi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116949/ --- (Updated March 23, 2014, 10:15 p.m.) Review request for Calligra and Jaro

Re: Review Request 116949: close all tabs command added

2014-03-23 Thread Jarosław Staniek
> On March 23, 2014, 9:57 p.m., Jarosław Staniek wrote: > > kexi/main/KexiMainWindow.cpp, line 226 > > > > > > When there are zero tabs you're returning uninitialized value. > > Vishwa Modi wrote: > Will the

Re: Review Request 116949: close all tabs command added

2014-03-23 Thread Vishwa Modi
> On March 23, 2014, 9:57 p.m., Jarosław Staniek wrote: > > kexi/main/KexiMainWindow.cpp, line 226 > > > > > > When there are zero tabs you're returning uninitialized value. Will the function closeAllTabs() be c

Re: Review Request 116949: close all tabs command added

2014-03-23 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116949/#review53863 --- kexi/main/KexiMainWindow.cpp

Re: Review Request 116949: close all tabs command added

2014-03-23 Thread Vishwa Modi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116949/ --- (Updated March 23, 2014, 9:36 p.m.) Review request for Calligra and Jaros

Re: Review Request 116844: update minimum cmake requirement to 2.8.10, use cmake built-in FindGLEW.cmake

2014-03-23 Thread Yue Liu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116844/ --- (Updated March 23, 2014, 9:31 p.m.) Status -- This change has been d

Re: Review Request 116986: Do not remove table prefix when it is needed

2014-03-23 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116986/ --- (Updated March 23, 2014, 9:19 p.m.) Status -- This change has been m

Re: Review Request 116986: Do not remove table prefix when it is needed

2014-03-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116986/#review53849 --- This review has been submitted with commit bdab8c724e91e59e24

Re: Review Request 116844: update minimum cmake requirement to 2.8.10, use cmake built-in FindGLEW.cmake

2014-03-23 Thread Jaroslaw Staniek
Thanks Yue! On 23 March 2014 22:09, Yue Liu wrote: > ok. I'll revert the change. > > On Sun, Mar 23, 2014 at 4:46 PM, Jaroslaw Staniek wrote: > > I have 2.8.9 on my pretty modern machine. Also I know people using Ubuntu > > 12.10 or 12.04 not willing to install backports for THIS single reason

Re: Review Request 116986: Do not remove table prefix when it is needed

2014-03-23 Thread Radosław Wicik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116986/#review53848 --- Ship it! Ship It! - Radosław Wicik On March 23, 2014, 12:2

Re: Review Request 116844: update minimum cmake requirement to 2.8.10, use cmake built-in FindGLEW.cmake

2014-03-23 Thread Yue Liu
ok. I'll revert the change. On Sun, Mar 23, 2014 at 4:46 PM, Jaroslaw Staniek wrote: > I have 2.8.9 on my pretty modern machine. Also I know people using Ubuntu > 12.10 or 12.04 not willing to install backports for THIS single reason :) > > Summing up I really recommend to just backport; I've fol

Re: Review Request 116986: Do not remove table prefix when it is needed

2014-03-23 Thread Tomasz Olszak
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116986/#review53847 --- Ship it! Ship It! - Tomasz Olszak On March 22, 2014, 11:28

Re: Review Request 116986: Do not remove table prefix when it is needed

2014-03-23 Thread Adam Pigg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116986/#review53845 --- Ship it! Ship It! - Adam Pigg On March 22, 2014, 11:28 p.m

Re: Review Request 116844: update minimum cmake requirement to 2.8.10, use cmake built-in FindGLEW.cmake

2014-03-23 Thread Jaroslaw Staniek
I have 2.8.9 on my pretty modern machine. Also I know people using Ubuntu 12.10 or 12.04 not willing to install backports for THIS single reason :) ​Summing up I really ​recommend to just backport; I've followed this approach with mysql/pgsql detection code and I am still using FindCalligraSqlite.

Re: Review Request 116844: update minimum cmake requirement to 2.8.10, use cmake built-in FindGLEW.cmake

2014-03-23 Thread Yue Liu
We can do that if there are platforms without 2.8.10 we need to support. On Sun, Mar 23, 2014 at 2:29 PM, Jaroslaw Staniek wrote: > Hi, can't we just back port the cake file? > > > On Sunday, 23 March 2014, Yue Liu wrote: >> This is an automatically generated e-mail. To reply, visit: >> https://

Re: Review Request 116949: close all tabs command added

2014-03-23 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116949/#review53837 --- kexi/main/KexiMainWindow.cpp

Review Request 116990: Deduplicate dirs in one more place where moc fails due to too long command line.

2014-03-23 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116990/ --- Review request for Calligra. Repository: calligra Description ---

Re: Review Request 116949: close all tabs command added

2014-03-23 Thread Vishwa Modi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116949/ --- (Updated March 23, 2014, 7:09 p.m.) Review request for Calligra and Jaros

Re: Review Request 116844: update minimum cmake requirement to 2.8.10, use cmake built-in FindGLEW.cmake

2014-03-23 Thread Jaroslaw Staniek
Hi, can't we just back port the cake file? On Sunday, 23 March 2014, Yue Liu wrote: > This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116844/ > > This change has been marked as submitted. > > Review request for Calligra. > By Yue Liu. > > Updated Marc

Re: Review Request 116844: update minimum cmake requirement to 2.8.10, use cmake built-in FindGLEW.cmake

2014-03-23 Thread Yue Liu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116844/ --- (Updated March 23, 2014, 6:22 p.m.) Status -- This change has been m

Re: Review Request 115114: Rename lst1 and lst2 variables

2014-03-23 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115114/ --- (Updated March 23, 2014, 12:55 p.m.) Status -- This change has been

Re: Review Request 115116: Disable KoM2MMLForumulaTool also on MinGW

2014-03-23 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115116/ --- (Updated March 23, 2014, 12:55 p.m.) Status -- This change has been

Re: Review Request 115114: Rename lst1 and lst2 variables

2014-03-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115114/#review53808 --- This review has been submitted with commit 1ffe6b3f7a8da45140

Re: Review Request 115116: Disable KoM2MMLForumulaTool also on MinGW

2014-03-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115116/#review53807 --- This review has been submitted with commit b5832b98ecaad66982

Re: Review Request 116915: Fix Bug 305618

2014-03-23 Thread Wenchao Li
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116915/ --- (Updated March 23, 2014, 7:54 a.m.) Review request for Calligra. Change