Re: Review Request 116915: Fix Bug 305618

2014-03-22 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116915/#review53779 --- You are on the right track. I have pointed out some small stuf

Re: Review Request 116915: Fix Bug 305618

2014-03-22 Thread Wenchao Li
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116915/ --- (Updated March 23, 2014, 2:47 a.m.) Review request for Calligra. Change

Re: Review Request 115611: KoFileDialogHelper => KoFileDialog refactor

2014-03-22 Thread Yue Liu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115611/ --- (Updated March 23, 2014, 12:21 a.m.) Status -- This change has been

Re: Review Request 116949: close all tabs command added

2014-03-22 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116949/#review53777 --- Please set branch to master in this review and always remember

Review Request 116986: Do not remove table prefix when it is needed

2014-03-22 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116986/ --- Review request for Calligra, Andrius da Costa Ribas, Oleg Kukharchuk, Adam

Build failed in Jenkins: calligra_master » All,LINBUILDER #157

2014-03-22 Thread KDE CI System
See Changes: [yue.liu] fix conflict [yue.liu] kfiledialog=>kofiledialog [yue.liu] fix compile on osx [yue.liu] rename FileDialogType enums [yue.liu] clean up stencilboxdocker [yue.liu] update minimum cmake

Re: Review Request 116949: close all tabs command added

2014-03-22 Thread Jarosław Staniek
> On March 21, 2014, 7:50 p.m., Jarosław Staniek wrote: > > kexi/main/KexiMainWindow.cpp, line 173 > > > > > > &C accelerator is used already in this context menu (line 170) so let's > > use something other, e.g

Re: Review Request 116949: close all tabs command added

2014-03-22 Thread Vishwa Modi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116949/ --- (Updated March 22, 2014, 4:36 p.m.) Review request for Calligra and Jaros

Re: Review Request 116949: close all tabs command added

2014-03-22 Thread Vishwa Modi
> On March 21, 2014, 7:50 p.m., Jarosław Staniek wrote: > > kexi/main/KexiMainWindow.cpp, line 173 > > > > > > &C accelerator is used already in this context menu (line 170) so let's > > use something other, e.g

gsoc ranking meeting for calligra

2014-03-22 Thread Boudewijn Rempt
Hi! Shall we have the usual gsoc ranking meeting tomorrow evening? 20:00 CET? Or would another date/time be better? Mentors-only, of course, on #calligra-gsoc. Boud ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/

Re: Review Request 116976: do not use a null member

2014-03-22 Thread Jaime Torres Amate
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116976/ --- (Updated March 22, 2014, 12:46 p.m.) Status -- This change has been

Review Request 116976: do not use a null member

2014-03-22 Thread Jaime Torres Amate
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116976/ --- Review request for Calligra and Boudewijn Rempt. Bugs: 331652 http://