Re: Review Request 116844: update minimum cmake requirement to 2.8.10, use cmake built-in FindGLEW.cmake

2014-03-21 Thread Yue Liu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116844/ --- (Updated March 22, 2014, 12:36 a.m.) Review request for Calligra. Chang

Re: Review Request 116949: close all tabs command added

2014-03-21 Thread Jarosław Staniek
> On March 21, 2014, 9:09 p.m., Radosław Wicik wrote: > > kexi/main/KexiMainWindow.cpp, line 216 > > > > > > Maby you should use qobject_cast instead of dynamic_cast? Cannot be used because KexiMainWindowIface::

Re: Review Request 116949: close all tabs command added

2014-03-21 Thread Radosław Wicik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116949/#review53717 --- kexi/main/KexiMainWindow.h

Re: Review Request 116949: close all tabs command added

2014-03-21 Thread Jarosław Staniek
> On March 21, 2014, 7:50 p.m., Jarosław Staniek wrote: > > kexi/main/KexiMainWindow.cpp, line 210 > > > > > > Looks complex... > > > > 1.1. One hidden requirement is that closeWindowForTab() can return

Re: Review Request 116611: Eigen3 support

2014-03-21 Thread Maximiliano Curia
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116611/ --- (Updated March 21, 2014, 8:48 p.m.) Review request for Calligra. Change

Re: Review Request 116949: close all tabs command added

2014-03-21 Thread Vishwa Modi
> On March 21, 2014, 7:50 p.m., Jarosław Staniek wrote: > > kexi/main/KexiMainWindow.cpp, line 210 > > > > > > Looks complex... > > > > 1.1. One hidden requirement is that closeWindowForTab() can return

Re: Review Request 116949: close all tabs command added

2014-03-21 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116949/#review53647 --- kexi/main/KexiMainWindow.h

Review Request 116949: close all tabs command added

2014-03-21 Thread Vishwa Modi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116949/ --- Review request for Calligra and Jarosław Staniek. Repository: calligra