Re: Review Request 115537: Fix misplaced combobox editor and unnecessary scrollbars

2014-02-16 Thread Andrius da Costa Ribas
> On Feb. 16, 2014, 9:37 p.m., Andrius da Costa Ribas wrote: > > I've tried this, but I still get the unneeded extra scrollbars in the > > example of Bug 330886. Maybe it needs to compensate the extra left margin > > on Windows? > > Jarosław Staniek wrote: > Thanks for the review. Needs ex

Re: Review Request 115537: Fix misplaced combobox editor and unnecessary scrollbars

2014-02-16 Thread Jarosław Staniek
> On Feb. 16, 2014, 9:37 p.m., Andrius da Costa Ribas wrote: > > I've tried this, but I still get the unneeded extra scrollbars in the > > example of Bug 330886. Maybe it needs to compensate the extra left margin > > on Windows? Thanks for the review. Needs extra testing on windows. The questi

Re: Review Request 115694: Re-add missing "Clear Table Contents" action

2014-02-16 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115694/#review49995 --- Ship it! Ship It! - Andrius da Costa Ribas On Feb. 12, 201

Re: Review Request 115537: Fix misplaced combobox editor and unnecessary scrollbars

2014-02-16 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115537/#review49993 --- I've tried this, but I still get the unneeded extra scrollbars

Re: Review Request 115592: Add iifNotEmpty() utility functions

2014-02-16 Thread Andrius da Costa Ribas
> On Feb. 16, 2014, 6:16 p.m., Andrius da Costa Ribas wrote: > > Is there some specific place this is intended to be used? nevermind, didn't notice that #115594 uses it - Andrius da Costa --- This is an automatically generated e-mail. T

Re: Review Request 115594: Make queries with lookup field and table alias work

2014-02-16 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115594/#review49990 --- Ship it! good for 330910, still not for 330410 but looks like

Re: Review Request 115592: Add iifNotEmpty() utility functions

2014-02-16 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115592/#review49989 --- Ship it! Ship It! - Andrius da Costa Ribas On Feb. 8, 2014

Re: Review Request 115593: Add more table alias -related functions for queries

2014-02-16 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115593/#review49988 --- Ship it! Ship It! - Andrius da Costa Ribas On Feb. 8, 2014

Re: Review Request 115592: Add iifNotEmpty() utility functions

2014-02-16 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115592/#review49955 --- Is there some specific place this is intended to be used? - A

Re: Review Request 115314: Fix crash with custom sized reports

2014-02-16 Thread Andrius da Costa Ribas
> On Feb. 5, 2014, 11:48 a.m., Jarosław Staniek wrote: > > libs/koreport/wrtembed/KoReportDesigner.cpp, line 239 > > > > > > Check this value, if it's "Custom" or "" then perform steps for the > > custom size.

Re: Review Request 115314: Fix crash with custom sized reports

2014-02-16 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115314/ --- (Updated Feb. 16, 2014, 6:11 p.m.) Review request for Calligra, Friedrich

Re: mixing double and qreal types

2014-02-16 Thread Boudewijn Rempt
On Friday 14 February 2014 Feb 15:41:36 Rex Dieter wrote: > > Went with option 3, holler if anything breaks. > Yes, awesome. Many thanks! -- Boudewijn Rempt http://www.valdyas.org, http://www.krita.org, http://www.boudewijnrempt.nl ___ calligra-de