Re: Review Request 115195: Fix of BUG:317648

2014-01-23 Thread Nicolas Brack
> On Jan. 21, 2014, 7:54 p.m., Nicolas Brack wrote: > > This is incredible how long can breakpoint->run->check cycles can last when > > you do not know the code that well. > > Still no commit access since yesterday obviously. > > > > Boudewijn Rempt wrote: > It looks good -- but it might ac

Re: Review Request 115107: Link tests to kritaimage instead of using directly its sources

2014-01-23 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115107/ --- (Updated Jan. 23, 2014, 8:18 p.m.) Status -- This change has been ma

Re: Review Request 115108: Add some #ifdef guards to winquirks to avoid clash with the same definitions on kdewin

2014-01-23 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115108/ --- (Updated Jan. 23, 2014, 8:16 p.m.) Status -- This change has been ma

Re: Review Request 115113: Static libs must come first in linkage order

2014-01-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115113/#review48162 --- This review has been submitted with commit 5f0a8e4208a10f5d6b

Re: Review Request 115108: Add some #ifdef guards to winquirks to avoid clash with the same definitions on kdewin

2014-01-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115108/#review48163 --- This review has been submitted with commit c6f3167880c18ce6e2

Re: Review Request 115113: Static libs must come first in linkage order

2014-01-23 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115113/ --- (Updated Jan. 23, 2014, 8:16 p.m.) Status -- This change has been ma

Re: Review Request 115195: Fix of BUG:317648

2014-01-23 Thread Boudewijn Rempt
> On Jan. 21, 2014, 7:54 p.m., Nicolas Brack wrote: > > This is incredible how long can breakpoint->run->check cycles can last when > > you do not know the code that well. > > Still no commit access since yesterday obviously. > > > > Boudewijn Rempt wrote: > It looks good -- but it might ac

Re: Review Request 115195: Fix of BUG:317648

2014-01-23 Thread Nicolas Brack
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115195/ --- (Updated Jan. 23, 2014, 6:26 p.m.) Status -- This change has been ma

Re: Review Request 115247: Remove ifdef for X11 around a method which is not X11 specific

2014-01-23 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115247/ --- (Updated Jan. 23, 2014, 11:32 a.m.) Status -- This change has been m

Re: Review Request 115247: Remove ifdef for X11 around a method which is not X11 specific

2014-01-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115247/#review48104 --- This review has been submitted with commit f5be1d4b70e421fc5a

Re: Review Request 115107: Link tests to kritaimage instead of using directly its sources

2014-01-23 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115107/#review48100 --- Ship it! I'm fine with this -- in any case, i don't build the

Re: Review Request 115113: Static libs must come first in linkage order

2014-01-23 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115113/#review48101 --- Ship it! Ship It! - Boudewijn Rempt On Jan. 19, 2014, 3:42

Re: Review Request 115108: Add some #ifdef guards to winquirks to avoid clash with the same definitions on kdewin

2014-01-23 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115108/#review48099 --- Ship it! Ship It! - Boudewijn Rempt On Jan. 19, 2014, 3:42

Re: Review Request 115247: Remove ifdef for X11 around a method which is not X11 specific

2014-01-23 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115247/#review48098 --- Ship it! Ship It! - Boudewijn Rempt On Jan. 23, 2014, 8:36

Review Request 115247: Remove ifdef for X11 around a method which is not X11 specific

2014-01-23 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115247/ --- Review request for Calligra. Repository: calligra Description ---