Re: Review Request 115108: Add some #ifdef guards to winquirks to avoid clash with the same definitions on kdewin

2014-01-22 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115108/#review48089 --- This one is not needed anymore after review #115128 got submit

Re: Review Request 115129: Use kdewin's utsname.h instead of calling directly the equivalent winapi

2014-01-22 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115129/ --- (Updated Jan. 23, 2014, 12:54 a.m.) Status -- This change has been m

Re: Review Request 115128: Only add winquirks to include path if kdewin is not present

2014-01-22 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115128/ --- (Updated Jan. 23, 2014, 12:54 a.m.) Status -- This change has been m

Re: Review Request 115109: _isnan is present only in MSVC's , for MinGW we still use std::isnan

2014-01-22 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115109/ --- (Updated Jan. 23, 2014, 12:51 a.m.) Status -- This change has been m

Re: Review Request 115128: Only add winquirks to include path if kdewin is not present

2014-01-22 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115128/ --- (Updated Jan. 23, 2014, 12:20 a.m.) Review request for Calligra and Boude

Re: Review Request 115195: Fix of BUG:317648

2014-01-22 Thread Boudewijn Rempt
> On Jan. 21, 2014, 7:54 p.m., Nicolas Brack wrote: > > This is incredible how long can breakpoint->run->check cycles can last when > > you do not know the code that well. > > Still no commit access since yesterday obviously. > > It looks good -- but it might actually clash with a patch that I

Re: Review Request 115149: Quick fix of BUG:322951

2014-01-22 Thread Nicolas Brack
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115149/ --- (Updated Jan. 22, 2014, 2:21 p.m.) Status -- This change has been ma