Review Request 115133: Make Shift+Return and Escape shortcuts work in table and form data views

2014-01-19 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115133/ --- Review request for Calligra, Oleg Kukharchuk, Adam Pigg, Dimitrios Tanis,

Re: Review Request 115128: Only add winquirks to include path if kdewin is not present

2014-01-19 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115128/#review47733 --- Ship it! - Jarosław Staniek On Jan. 19, 2014, 6:01 p.m., An

Re: Review Request 115128: Only add winquirks to include path if kdewin is not present

2014-01-19 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115128/#review47734 --- Ship it! - Jarosław Staniek On Jan. 19, 2014, 6:01 p.m., An

Re: Review Request 115129: Use kdewin's utsname.h instead of calling directly the equivalent winapi

2014-01-19 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115129/#review47732 --- Ship it! Great work! - Jarosław Staniek On Jan. 19, 2014,

Re: Review Request 114994: Fix bug: data is not saved in form combo boxes

2014-01-19 Thread Jarosław Staniek
> On Jan. 19, 2014, 6:38 p.m., Andrius da Costa Ribas wrote: > > I see this was already commited in master, will it be backported to 2.8 too? Yep, just not pushed. Done now, thanks for this note. - Jarosław --- This is an automatically

Re: Review Request 114994: Fix bug: data is not saved in form combo boxes

2014-01-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114994/#review47728 --- This review has been submitted with commit c64c07fb40b3da9faa

Re: Review Request 114994: Fix bug: data is not saved in form combo boxes

2014-01-19 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114994/ --- (Updated Jan. 19, 2014, 7:46 p.m.) Status -- This change has been ma

Re: Review Request 114994: Fix bug: data is not saved in form combo boxes

2014-01-19 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114994/#review47723 --- Ship it! I see this was already commited in master, will it b

Review Request 115129: Use kdewin's utsname.h instead of calling directly the equivalent winapi

2014-01-19 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115129/ --- Review request for Calligra and Jarosław Staniek. Repository: calligra

Review Request 115128: Only add winquirks to include path if kdewin is not present

2014-01-19 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115128/ --- Review request for Calligra and Boudewijn Rempt. Repository: calligra D

Re: Review Request 115115: Fix for bug #327110 - Crash when trying to insert notes

2014-01-19 Thread Thorsten Zachmann
> On Jan. 19, 2014, 6:12 a.m., Thorsten Zachmann wrote: > > Nice patch please commit. Cool to see you around again. > > Fredy Yanardi wrote: > Thanks for reviewing, shall I commit it to 2.8 branch as well? Yes please - Thorsten ---

Re: Review Request 115115: Fix for bug #327110 - Crash when trying to insert notes

2014-01-19 Thread Fredy Yanardi
> On Jan. 19, 2014, 6:12 a.m., Thorsten Zachmann wrote: > > Nice patch please commit. Cool to see you around again. Thanks for reviewing, shall I commit it to 2.8 branch as well? - Fredy --- This is an automatically generated e-mail. To