Re: Review Request 114468: fix linking error on FillProcessingVisitorTest

2013-12-21 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114468/ --- (Updated Dec. 21, 2013, 10:05 p.m.) Status -- This change has been di

Re: Review Request 114468: fix linking error on FillProcessingVisitorTest

2013-12-21 Thread Andrius da Costa Ribas
> On Dec. 17, 2013, 2:05 p.m., Dmitry Kazakov wrote: > > Oh.. I guess it is better to just remove defaulttools linking in the test, > > because it is not needed anymore :) It was just a copy-paste error I guess. > > Boudewijn Rempt wrote: > Yes, I think so too. I don't actually build the te

Re: Review Request 114457: Fix issuing rng2cpp on Windows.

2013-12-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114457/#review46017 --- This review has been submitted with commit 911e112d45b8d3eb167

Re: Review Request 114457: Fix issuing rng2cpp on Windows.

2013-12-21 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114457/ --- (Updated Dec. 21, 2013, 10:01 p.m.) Status -- This change has been ma

Re: Review Request 114456: Fix FindGSL on Windows.

2013-12-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114456/#review46016 --- This review has been submitted with commit 6d13476662197a59786

Re: Review Request 114456: Fix FindGSL on Windows.

2013-12-21 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114456/ --- (Updated Dec. 21, 2013, 10:01 p.m.) Status -- This change has been ma

Re: Review Request 114578: Fix crash in SnapGuideDocker

2013-12-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114578/#review45983 --- This review has been submitted with commit 3fa081c65622c19c813

Re: Review Request 114578: Fix crash in SnapGuideDocker

2013-12-21 Thread Elvis Stansvik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114578/ --- (Updated Dec. 21, 2013, 10:06 a.m.) Status -- This change has been ma

Re: Review Request 114578: Fix crash in SnapGuideDocker

2013-12-21 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114578/#review45979 --- Ship it! Ship It! - Boudewijn Rempt On Dec. 20, 2013, 9:59