Review Request 112904: Pivot Tables Improved

2013-09-23 Thread Jigar Raisinghani
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112904/ --- Review request for Calligra and Inge Wallin. Description --- The foll

Re: [calligra/calligra-qt5-rempt] sheets/part: comment out the loading of tools - or whatever this code does

2013-09-23 Thread Boudewijn Rempt
On Monday 23 September 2013 Sep 08:52:54 C. Boemann wrote: > Git commit 87ea1aba8b0308a5bb075867efedff3d71aecfb7 by C. Boemann. > Committed on 23/09/2013 at 08:49. > Pushed by boemann into branch 'calligra-qt5-rempt'. > > comment out the loading of tools - or whatever this code does It should lo

Re: [calligra/calligra-qt5-rempt] sheets/part: Comment out some code that doesn't seem to have any effect besides crashing sheets

2013-09-23 Thread Boudewijn Rempt
But _why_ does it crash? This code is indeed needed to load some Sheets plugins, and it's easy enough to find out which ones: plugins/scripting/sheetsscripting.desktop:X-KDE-ServiceTypes=Sheets/ViewPlugin plugins/solver/sheetssolver.desktop:X-KDE-ServiceTypes=Sheets/ViewPlugin pivottables/sheetsp