Re: Review Request 111990: make calligra plugins kxmlguiclient instead of kpart

2013-08-11 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111990/ --- (Updated Aug. 12, 2013, 6:44 a.m.) Status -- This change has been mar

Planning mass rename of pot files in Calligra

2013-08-11 Thread Friedrich W. H. Kossebau
Hi, I have been adding some proper namespace to the names of some Calligra modules the last weeks. The last thing to do will be to also properly namespace the related po/pot files. See http://websvn.kde.org/trunk/l10n-kde4/templates/messages/calligra/ for generic names like CommentShape.pot,

Re: Review Request 111990: make calligra plugins kxmlguiclient instead of kpart

2013-08-11 Thread Boudewijn Rempt
> On Aug. 11, 2013, 4 a.m., Friedrich W. H. Kossebau wrote: > > braindump/plugins/quickstates/BraindumpQuickStatesPlugin.h, line 25 > > > > > > What about adding a class CalligraPlugin : public QObject, public > >

Automatic checking of the sources on global level

2013-08-11 Thread Inge Wallin
I have written a new python script a bit like fixsrc.py called chksrc.py. Like the name suggests it only checks and reports on problems, it doesn't fix anything. This first version checks for faulty or non-existant include guards, which is per file, and for export macros, which is per director

Re: Review Request 111960: Patch to support single layered grayscale photoshop documents

2013-08-11 Thread Siddharth Sharma
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111960/ --- (Updated Aug. 11, 2013, 11:12 a.m.) Status -- This change has been ma

Re: Review Request 111954: proper use filter_ products flag to enable/disable whole app filters

2013-08-11 Thread Friedrich W. H. Kossebau
> On Aug. 9, 2013, 8:20 a.m., Friedrich W. H. Kossebau wrote: > > Hi Sebastian, > > > > In the design of these product definition macros currently all the rules > > are whitelisting rules, not blacklisting rules. > > The FILTER_ products are kind of meta-products (or rather > > productsets) w

Re: Review Request 111990: make calligra plugins kxmlguiclient instead of kpart

2013-08-11 Thread Friedrich W. H. Kossebau
> On Aug. 11, 2013, 4 a.m., Friedrich W. H. Kossebau wrote: > > braindump/plugins/quickstates/BraindumpQuickStatesPlugin.cpp, line 38 > > > > > > No forward-passing of the parent object to the QObject? > > I wo

Re: Review Request 111960: Patch to support single layered grayscale photoshop documents

2013-08-11 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111960/#review37501 --- you already have a ship-it Such minor issues are not worth ma

Re: Review Request 111990: make calligra plugins kxmlguiclient instead of kpart

2013-08-11 Thread C. Boemann
> On Aug. 11, 2013, 4 a.m., Friedrich W. H. Kossebau wrote: > > braindump/plugins/quickstates/BraindumpQuickStatesPlugin.h, line 25 > > > > > > What about adding a class CalligraPlugin : public QObject, public > >

Re: Review Request 111990: make calligra plugins kxmlguiclient instead of kpart

2013-08-11 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111990/#review37499 --- Tested if it is working, and it is. I have no problem with the