Build failed in Jenkins: calligra_master #1406

2013-08-04 Thread KDE CI System
See Changes: [jos] Add test for ppt conversion to odp. [jos] Simple test improvements. [jos] Nicer output. [jos] Update test document to master. [jos] Change indent and attrib order. [jos] Be more specific about the attribute types. --

Re: Review Request 111773: Add api for writing ODF that is generated from the ODF RNG file

2013-08-04 Thread Friedrich W. H. Kossebau
Am Sonntag, 4. August 2013, 18:48:17 schrieb Jos van den Oever: > > On Aug. 4, 2013, 5:57 p.m., Friedrich W. H. Kossebau wrote: > > > Meh, too late, committed while I was giving it finally also a look. > > > > Please still pick up the following comments and do a fix-up commit: > Thanks for the tho

Re: [calligra] /: Add api for writing ODF that is generated from the ODF RNG file.

2013-08-04 Thread Sebastian Sauer
On 08/05/2013 02:16 AM, Jos van den Oever wrote: On 08/04/13 20:25, Friedrich W. H. Kossebau wrote: really cool work from Jos, happy to see it having made it into Calligra master So am I. Glad I blew off the dust from this one. Having finally given the patch I look as well I found I have a re

Re: [calligra] /: Add api for writing ODF that is generated from the ODF RNG file.

2013-08-04 Thread Jos van den Oever
On 08/04/13 20:25, Friedrich W. H. Kossebau wrote: really cool work from Jos, happy to see it having made it into Calligra master So am I. Glad I blew off the dust from this one. Having finally given the patch I look as well I found I have a really hard time reading all_the_created_methods_an

Re: Review Request 111773: Add api for writing ODF that is generated from the ODF RNG file

2013-08-04 Thread Jos van den Oever
> On Aug. 4, 2013, 5:57 p.m., Friedrich W. H. Kossebau wrote: > > Meh, too late, committed while I was giving it finally also a look. > > > > Please still pick up the following comments and do a fix-up commit: Thanks for the thorough look. You caught one bug and quite some style issues. wrt to

Re: [calligra] /: Add api for writing ODF that is generated from the ODF RNG file.

2013-08-04 Thread Friedrich W. H. Kossebau
Hi, really cool work from Jos, happy to see it having made it into Calligra master :) Am Sonntag, 4. August 2013, 17:41:20 schrieb Jos van den Oever: > Example: > Instead of writing: > == > xmlWriter->startElement("text:p"); > xmlWriter->addAttribute("text:style-name", "italic"); > xmlWri

Re: Review Request 111773: Add api for writing ODF that is generated from the ODF RNG file

2013-08-04 Thread Jos van den Oever
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111773/ --- (Updated Aug. 4, 2013, 5:42 p.m.) Review request for Calligra. Descripti

Re: Review Request 111773: Add api for writing ODF that is generated from the ODF RNG file

2013-08-04 Thread Jos van den Oever
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111773/ --- (Updated Aug. 4, 2013, 5:43 p.m.) Status -- This change has been mark

Re: Review Request 111773: Add api for writing ODF that is generated from the ODF RNG file

2013-08-04 Thread Jos van den Oever
> On Aug. 4, 2013, 12:08 p.m., Inge Wallin wrote: > > S much nicer! Good work! > > > > This time I only had some nits to pick and some questions. But I don't see > > a need for another round after the issues are fixed. Thanks for reviewing this large patch again. The issues you raised w

Nominations to Linux Journal's Readers Choice Awards

2013-08-04 Thread Inge Wallin
Since this seems to be on all the other free office applications' mailing lists, I thought it would be appropriate to do it here as well. Linux Journal has a yearly poll about the "best of ..." in a lot of categories, including office applications. I suggest that you all click on the link bel

Re: Review Request 110700: Remove unused storage/API from StyleManager

2013-08-04 Thread Elvis Stansvik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110700/ --- (Updated Aug. 4, 2013, 12:36 p.m.) Status -- This change has been dis

Re: Review Request 110408: Improve the styles handling in libs/odf/styles

2013-08-04 Thread Inge Wallin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110408/ --- (Updated Aug. 4, 2013, 12:10 p.m.) Status -- This change has been dis

Re: Review Request 111773: Add api for writing ODF that is generated from the ODF RNG file

2013-08-04 Thread Inge Wallin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111773/#review37053 --- Ship it! S much nicer! Good work! This time I only had

Re: Review Request 111787: Page Layout improvements for Words

2013-08-04 Thread Elvis Stansvik
> On Aug. 4, 2013, 11:21 a.m., Inge Wallin wrote: > > words/part/pagetool/KWPageTool.cpp, line 272 > > > > > > is "style" the name of the style? If so, I think it would be clearer > > if the parameter was called