Re: Review Request 111545: Port komain away from KParts

2013-07-23 Thread Boudewijn Rempt
> On July 18, 2013, 2:55 p.m., Friedrich W. H. Kossebau wrote: > > libs/main/KoMainWindow.cpp, lines 202-203 > > > > > > What is the difference between "activePart" and "m_activePart"? > > > > And shouldn

An Interesting Observation (Huge Regression in Sheets)

2013-07-23 Thread jigar raisinghani
Hi, While digging into the code for the shape bug I realized that Sheets is not really ignoring the shape after adding them. The problem is that handling of shapes is not proper. To Reproduce: Add a shape. Switch to Shape Handling Docker and now move the cursor over the shape. In case

Re: Review Request 111545: Port komain away from KParts

2013-07-23 Thread Friedrich W. H. Kossebau
> On July 21, 2013, 9:59 p.m., Friedrich W. H. Kossebau wrote: > > > For easy testing I recommend checking out the krita-mvc-rempt branch > > > > Does not build for me: > > > > [ 68%] Building CXX object > > krita/app/CMakeFiles/krita.dir/krita_automoc.cpp.o > > In file included from > > /hom

Re: Review Request 111545: Port komain away from KParts

2013-07-23 Thread Boudewijn Rempt
> On July 21, 2013, 9:59 p.m., Friedrich W. H. Kossebau wrote: > > > For easy testing I recommend checking out the krita-mvc-rempt branch > > > > Does not build for me: > > > > [ 68%] Building CXX object > > krita/app/CMakeFiles/krita.dir/krita_automoc.cpp.o > > In file included from > > /hom

Re: Review Request 111545: Port komain away from KParts

2013-07-23 Thread Boudewijn Rempt
> On July 21, 2013, 9:59 p.m., Friedrich W. H. Kossebau wrote: > > > For easy testing I recommend checking out the krita-mvc-rempt branch > > > > Does not build for me: > > > > [ 68%] Building CXX object > > krita/app/CMakeFiles/krita.dir/krita_automoc.cpp.o > > In file included from > > /hom

Review Request 111667: Make libcalligrachartshape a static lib, rename to libchartshapecore and no longer install it

2013-07-23 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111667/ --- Review request for Calligra and Inge Wallin. Description --- Because

Re: Review Request 111545: Port komain away from KParts

2013-07-23 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111545/#review36404 --- One issue I saw (as reported on irc): opening another file when

Re: Review Request 111545: Port komain away from KParts

2013-07-23 Thread Friedrich W. H. Kossebau
> On July 18, 2013, 2:55 p.m., Friedrich W. H. Kossebau wrote: > > libs/main/KoMainWindow.cpp, lines 202-203 > > > > > > What is the difference between "activePart" and "m_activePart"? > > > > And shouldn

Re: Review Request 111545: Port komain away from KParts

2013-07-23 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111545/#review36383 --- Still not completely reviewed. At least a set of new comments,

Review Request 111657: Project performance chart refresh

2013-07-23 Thread Alvaro Soliverez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111657/ --- Review request for Calligra. Description --- * When effort is added t

Re: Review Request 111411: Remove outdated kchartpart.desktop, there is no longer a kchartpart module

2013-07-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111411/#review36345 --- This review has been submitted with commit a27caa2b7a1a75afe55

Re: Review Request 111595: Turn some sequences of x += ... statements (with x a QString) into a long chain of additions (for QStringBuilder)

2013-07-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111595/#review36344 --- This review has been submitted with commit ee83b45a3d04ad61fc9

Re: Review Request 111411: Remove outdated kchartpart.desktop, there is no longer a kchartpart module

2013-07-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111411/#review36343 --- This review has been submitted with commit 7db39a21602a288b5ed

Re: Review Request 111595: Turn some sequences of x += ... statements (with x a QString) into a long chain of additions (for QStringBuilder)

2013-07-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111595/ --- (Updated July 23, 2013, 9:18 a.m.) Status -- This change has been mar

Re: Review Request 111411: Remove outdated kchartpart.desktop, there is no longer a kchartpart module

2013-07-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111411/ --- (Updated July 23, 2013, 9:18 a.m.) Status -- This change has been mar

Re: Review Request 111411: Remove outdated kchartpart.desktop, there is no longer a kchartpart module

2013-07-23 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111411/#review36334 --- Ship it! Yes, the chart part was removed a long time ago when

Re: Review Request 111595: Turn some sequences of x += ... statements (with x a QString) into a long chain of additions (for QStringBuilder)

2013-07-23 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111595/#review36333 --- Ship it! - Boudewijn Rempt On July 19, 2013, 10:07 a.m., Fri