Review Request 110965: fix broken conversion of results from koscript code evaluation in KRScriptHandler::evaluate()

2013-06-11 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110965/ --- Review request for Calligra, Sebastian Sauer and Jarosław Staniek. Descrip

Re: Review Request 110910: Refactored context menu creation code out of KoResourceItemChooser and into its own QMenu class

2013-06-11 Thread Friedrich W. H. Kossebau
> On June 11, 2013, 4:44 p.m., Friedrich W. H. Kossebau wrote: > > libs/widgets/KoResourceItemChooserContextMenu.h, lines 72-75 > > > > > > Why not setX here? Would be the usual pattern in Qt/KDE/Calligra. > >

Re: Review Request 110910: Refactored context menu creation code out of KoResourceItemChooser and into its own QMenu class

2013-06-11 Thread Sascha Suelzer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110910/ --- (Updated June 11, 2013, 7:29 p.m.) Review request for Calligra. Descript

Re: Review Request 110910: Refactored context menu creation code out of KoResourceItemChooser and into its own QMenu class

2013-06-11 Thread Sascha Suelzer
> On June 11, 2013, 4:44 p.m., Friedrich W. H. Kossebau wrote: > > libs/widgets/KoResourceItemChooser.cpp, line 937 > > > > > > Better add a comment why starting with 1 and not 0. > > E.g. I am wondering why,

Re: Review Request 110910: Refactored context menu creation code out of KoResourceItemChooser and into its own QMenu class

2013-06-11 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110910/#review34156 --- you are a good enough coder to get some very picky review, so y