Re: Review Request 109088: remove code variants for Qt versions below the current min.requ. 4.7.0

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109088/#review27873 --- Hm... I've just gotten a bit of a shock: on CentOS 6 (the curre

Re: Review Request 109088: remove code variants for Qt versions below the current min.requ. 4.7.0

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109088/#review27872 --- Ship it! Ship It! - C. Boemann On Feb. 21, 2013, 9:58 p.m.,

Review Request 109088: remove code variants for Qt versions below the current min.requ. 4.7.0

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109088/ --- Review request for Calligra. Description --- Came across some code fo

Re: Review Request 109082: Separate files for the app into own subdir "app/" for Stage and Words

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109082/ --- (Updated Feb. 21, 2013, 7:49 p.m.) Review request for Calligra, C. Boemann

Re: Review Request 109082: Separate files for the app into own subdir "app/" for Stage and Words

> On Feb. 21, 2013, 7:01 p.m., C. Boemann wrote: > > perfectly fine with me, but two questions: > > > > have you made sure it still works on mac, if not then we probably should > > ask yue > > > > are there any changes needed for message extraction, and are we now talking > > different po pac

Re: Review Request 109082: Separate files for the app into own subdir "app/" for Stage and Words

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109082/#review27862 --- perfectly fine with me, but two questions: have you made sure

Re: Review Request 109082: Separate files for the app into own subdir "app/" for Stage and Words

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109082/#review27861 --- perfectly fine with me, but two questions: have you made sure

Re: Review Request 109071: Add a PRODUCTSET build config parameter (values ACTIVE, CREATIVE, DESKTOP, ALL)

> On Feb. 21, 2013, 8:08 a.m., Boudewijn Rempt wrote: > > CMakeLists.txt, line 46 > > > > > > Not only code: CREATIVEONY is used in many scripts for compiling Krita > > provided by 3rd parties, like David Revoy, i

Re: Review Request 109071: Add a PRODUCTSET build config parameter (values ACTIVE, CREATIVE, DESKTOP, ALL)

> On Feb. 21, 2013, 8:08 a.m., Boudewijn Rempt wrote: > > stage/app/CMakeLists.txt, line 1 > > > > > > Wouldn't it be better to have the moving of stuff to app directories in > > a separate patch, or at least commi

Review Request 109082: Separate files for the app into own subdir "app/" for Stage and Words

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109082/ --- Review request for Calligra, C. Boemann and Thorsten Zachmann. Description

Re: Review Request 109057: Normalize SIGNAL and SLOT signatures in kexi

> On Feb. 20, 2013, 9:29 p.m., Jarosław Staniek wrote: > > kexi/formeditor/editlistviewdialog.cpp, line 130 > > > > > > missing ',' > > Inge Wallin wrote: > Hmm, seems there was no comment even before. I'm s

Re: Review Request 109057: Normalize SIGNAL and SLOT signatures in kexi

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109057/#review27824 --- kexi/main/KexiMainWindow.cpp

Re: Review Request 109057: Normalize SIGNAL and SLOT signatures in kexi

> On Feb. 20, 2013, 9:29 p.m., Jarosław Staniek wrote: > > kexi/formeditor/editlistviewdialog.cpp, line 130 > > > > > > missing ',' Hmm, seems there was no comment even before. I'm surprised that it ever worked

Re: Review Request 109071: Add a PRODUCTSET build config parameter (values ACTIVE, CREATIVE, DESKTOP, ALL)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109071/#review27811 --- Really nice cleanup! Here are some remarks. CMakeLists.txt