Re: Review Request 108459: Refactor in KoText

2013-01-28 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108459/#review26347 --- This review has been submitted with commit 78e74eb447d8761f927

Review Request 108651: Nicer appearance of image after cropping.

2013-01-28 Thread Sven Langkamp
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108651/ --- Review request for Calligra. Description --- As described in bug 3134

Re: Review Request 108459: Refactor in KoText

2013-01-28 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108459/#review26343 --- Ship it! Looks good. Please commit. Nice work. - Thorsten Zac

Re: Review Request 108588: unoverload KoReportItemBase::render(...)

2013-01-28 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108588/#review26337 --- This review has been submitted with commit 20514013397f5eff150

Re: RFC: When to use #warning ?

2013-01-28 Thread Jaroslaw Staniek
On 28 January 2013 23:17, Friedrich W. H. Kossebau wrote: >> 47 warnings come from kexi/migration/mdb/src/mdbtools/libmdb and these >> won't be fixed since this is 3rd-party code that I prefer not to patch >> just for this reason. Please note that fixing glib-based C code may >> even introduce re

Re: Review Request 108588: unoverload KoReportItemBase::render(...)

2013-01-28 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108588/#review26336 --- Ship it! plugins/reporting/barcode/KoReportItemBarcode.cpp

Re: RFC: When to use #warning ?

2013-01-28 Thread Friedrich W. H. Kossebau
Hi Jarosław, Am Montag, 28. Januar 2013, 22:36:57 schrieb Jaroslaw Staniek: > Hello Friedrich, > I generally agree what you say here and will look step by step, which > would take 'some time'. I hope someone would help so below I explain > how. Good. At least I am tempted to continue my warning h

Re: RFC: When to use #warning ?

2013-01-28 Thread Jaroslaw Staniek
Hello Friedrich, I generally agree what you say here and will look step by step, which would take 'some time'. I hope someone would help so below I explain how. Nearly no new #warnings were added after Kexi started to compile with Qt 4. Any new code conforms to the guidelines and older is cleaned

RFC: When to use #warning ?

2013-01-28 Thread Friedrich W. H. Kossebau
Hi all and especially the Kexi developers :) the last days I spent some time to do little commits to decrease the currently quite high amount of warnings during a full build of Calligra. Most commits were some simple fixes like removing/hiding unused parameters/variables, so I felt free to skip

Re: RFC: Bumping min. KDE Platform version to 4.6.0

2013-01-28 Thread Inge Wallin
On Monday, January 28, 2013 19:33:22 Friedrich W. H. Kossebau wrote: > Hi Inge, > > Am Montag, 28. Januar 2013, 11:36:32 schrieb Inge Wallin: > > On Sunday, January 27, 2013 17:28:11 Friedrich W. H. Kossebau wrote: > > > Hi, > > > > > > while I was working on sheets/plugins/calendar/CalendarTool.

Re: Review Request 107580: Avoid compiler warning in Global.h for external projects using Sheets' components

2013-01-28 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107580/#review26328 --- Hi Philip, could you close this request as discarded, as this p

Re: RFC: Bumping min. KDE Platform version to 4.6.0

2013-01-28 Thread Friedrich W. H. Kossebau
Hi Inge, Am Montag, 28. Januar 2013, 11:36:32 schrieb Inge Wallin: > On Sunday, January 27, 2013 17:28:11 Friedrich W. H. Kossebau wrote: > > Hi, > > > > while I was working on sheets/plugins/calendar/CalendarTool.cpp to fix the > > code for the "deprecated!" warnings in there I wondered why we s

Re: Review Request 108459: Refactor in KoText

2013-01-28 Thread C. Boemann
> On Jan. 21, 2013, 6:59 a.m., C. Boemann wrote: > > libs/kotext/KoShapeAnchor.h, line 173 > > > > > > oh really - we don't support that at all > > > > > > C. Boemann wrote: > it's a real odf type - keep

Re: Review Request 108459: Refactor in KoText

2013-01-28 Thread C. Boemann
> On Jan. 25, 2013, 4:25 a.m., Thorsten Zachmann wrote: > > libs/kotext/commands/ChangeAnchorPropertiesCommand.cpp, line 49 > > > > > > Should that not delete the m_newLocation/m_oldLocation depending on > > which

Re: Review Request 108459: Refactor in KoText

2013-01-28 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108459/ --- (Updated Jan. 28, 2013, 6:03 p.m.) Review request for Calligra and Thorste

Re: RFC: Bumping min. KDE Platform version to 4.6.0

2013-01-28 Thread Inge Wallin
On Sunday, January 27, 2013 17:28:11 Friedrich W. H. Kossebau wrote: > Hi, > > while I was working on sheets/plugins/calendar/CalendarTool.cpp to fix the > code for the "deprecated!" warnings in there I wondered why we still depend > on KDE 4.3 as minimum platform, especially now that the min. req

Re: Review Request 108579: remove file FindKOfficeLibs.cmake.in and a duplicated line for creating FindCalligraLibs.cmake

2013-01-28 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108579/#review26292 --- This review has been submitted with commit ed9b4e632e95fb1b01b