Re: Review Request 108535: Clean out KoTextLoader of changetracking

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108535/#review25959 --- Ship it! can be committed to your branch - C. Boemann On Ja

Re: Review Request 108535: Clean out KoTextLoader of changetracking

> On Jan. 22, 2013, 6:18 a.m., C. Boemann wrote: > > libs/kotext/opendocument/KoTextLoader.cpp, line 413 > > > > > > hmm i don't think this should be removed though > > > > Luke De Mouy wrote: > the loadList

Re: Review Request 108535: Clean out KoTextLoader of changetracking

> On Jan. 22, 2013, 6:18 a.m., C. Boemann wrote: > > libs/kotext/opendocument/KoTextLoader.cpp, line 413 > > > > > > hmm i don't think this should be removed though > > the loadList call isn't actually removed ev

Re: Review Request 108535: Clean out KoTextLoader of changetracking

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108535/ --- (Updated Jan. 22, 2013, 6:37 a.m.) Review request for Calligra. Changes

Re: Review Request 108532: Fix crash in krita master on style combo

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108532/#review25955 --- Ship it! Ship It! - C. Boemann On Jan. 21, 2013, 7:41 p.m.,

Re: Review Request 108532: Fix crash in krita master on style combo

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108532/#review25954 --- though i would have made heading etc children of body text, I h

Re: Review Request 108535: Clean out KoTextLoader of changetracking

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108535/#review25952 --- libs/kotext/opendocument/KoTextLoader.cpp

Re: Review Request 108535: Clean out KoTextLoader of changetracking

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108535/#review25931 --- libs/kotext/opendocument/KoTextLoader.cpp

Re: Review Request 108532: Fix crash in krita master on style combo

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108532/#review25950 --- The crash is fixed. Unfortunately the styles are lost after sav

Re: Review Request 108535: Clean out KoTextLoader of changetracking

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108535/ --- (Updated Jan. 22, 2013, 3:56 a.m.) Review request for Calligra. Changes

Re: Review Request 108535: Clean out KoTextLoader of changetracking

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108535/ --- (Updated Jan. 22, 2013, 12:28 a.m.) Review request for Calligra. Changes

Review Request 108535: Clean out KoTextLoader of changetracking

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108535/ --- Review request for Calligra. Description --- Clear out the changetrac

Review Request 108532: Fix crash in krita master on style combo

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108532/ --- Review request for Calligra, C. Boemann and Sven Langkamp. Description ---

Re: Review Request 108478: fix for a broken algorithm type comparison in MsooXmlDiagramReader_p.cpp

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108478/#review25920 --- This review has been submitted with commit 00a9adc7abde0d5b485

Re: Review Request 107717: Move ElapsedTime class to a private header that wont be installed

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107717/#review25919 --- This review has been submitted with commit 436b64c0d7862360c08

Re: Review Request 108478: fix for a broken algorithm type comparison in MsooXmlDiagramReader_p.cpp

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108478/#review25918 --- This review has been submitted with commit 7c305e464324518a6f9

Re: Review Request 108509: Fix 313576: Use the doc of the correct part

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108509/#review25905 --- This review has been submitted with commit 3f354e094bc8e444944

Re: Review Request 108459: Refactor in KoText

> On Jan. 21, 2013, 6:59 a.m., C. Boemann wrote: > > libs/kotext/KoShapeAnchor.cpp, line 340 > > > > > > or not parented at all like anchor to page > > > > how do we save that - bug? not a bug it's an of

Re: Review Request 108459: Refactor in KoText

> On Jan. 21, 2013, 6:59 a.m., C. Boemann wrote: > > libs/kotext/KoShapeAnchor.h, line 173 > > > > > > oh really - we don't support that at all > > > > it's a real odf type - keeping issue - but not going to