Re: Review Request: Remove out-dated margin and spacing settings in UI files

2013-01-02 Thread Inge Wallin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108097/#review24541 --- Hmm, better check that you have valid Ui files after the change

Review Request: Remove out-dated margin and spacing settings in UI files

2013-01-02 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108097/ --- Review request for Calligra. Description --- There are a few left-ove

Re: Review Request: Make KoReport section editor dialogs use QDialogButtonBox

2013-01-02 Thread Jarosław Staniek
> On Jan. 2, 2013, 10:16 p.m., Jarosław Staniek wrote: > > I compiled/checked your changes, thanks for attention to details. > > > > 1. How about using KDialogButtonBox instead of QDialogButtonBox? (it's > > available in Qt Designer too) > > > > 2. While we're moving to QFormLayout I propose t

Re: Impementation-dependent casts from uchar to char

2013-01-02 Thread Jaroslaw Staniek
Done, thanks. -- regards / pozdrawiam, Jaroslaw Staniek Kexi & Calligra & KDE | http://calligra.org/kexi | http://kde.org Qt Certified Specialist | http://qt-project.org http://www.linkedin.com/in/jstaniek ___ calligra-devel mailing list calligra-dev

Re: Impementation-dependent casts from uchar to char

2013-01-02 Thread Marijn Kruisselbrink
On Wed, Jan 2, 2013 at 2:50 PM, Jaroslaw Staniek wrote: > On 2 January 2013 22:52, Marijn Kruisselbrink > wrote: > > On Wed, Jan 2, 2013 at 1:26 PM, Jaroslaw Staniek > wrote: > >> > >> Hello Marijn, > >> There are impementation-dependent casts from uchar to char: > > > > Ah yes, that is indeed

Re: Review Request: Make KoReport section editor dialogs use QDialogButtonBox

2013-01-02 Thread Friedrich W. H. Kossebau
> On Jan. 2, 2013, 10:16 p.m., Jarosław Staniek wrote: > > I compiled/checked your changes, thanks for attention to details. > > > > 1. How about using KDialogButtonBox instead of QDialogButtonBox? (it's > > available in Qt Designer too) > > > > 2. While we're moving to QFormLayout I propose t

Re: Impementation-dependent casts from uchar to char

2013-01-02 Thread Jaroslaw Staniek
On 2 January 2013 22:52, Marijn Kruisselbrink wrote: > On Wed, Jan 2, 2013 at 1:26 PM, Jaroslaw Staniek wrote: >> >> Hello Marijn, >> There are impementation-dependent casts from uchar to char: > > Ah yes, that is indeed not good. > >> Since this is your code, could you point me what are these va

Re: Review Request: Make KoReport section editor dialogs use QDialogButtonBox

2013-01-02 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108096/#review24521 --- I compiled/checked your changes, thanks for attention to detail

Re: Impementation-dependent casts from uchar to char

2013-01-02 Thread Marijn Kruisselbrink
On Wed, Jan 2, 2013 at 1:26 PM, Jaroslaw Staniek wrote: > Hello Marijn, > There are impementation-dependent casts from uchar to char: > Ah yes, that is indeed not good. Since this is your code, could you point me what are these values? > I assume I copied these values from whatever document docu

Review Request: Make KoReport section editor dialogs use QDialogButtonBox

2013-01-02 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108096/ --- Review request for Calligra, Jarosław Staniek and Adam Pigg. Description -

Impementation-dependent casts from uchar to char

2013-01-02 Thread Jaroslaw Staniek
Hello Marijn, There are impementation-dependent casts from uchar to char: filters/libmsooxml/MsooXmlImport.cpp: In member function ‘KTemporaryFile* MSOOXML::MsooXmlImport::tryDecryptFile(QString&)’: filters/libmsooxml/MsooXmlImport.cpp:484:89: warning: narrowing conversion of ‘254’ from ‘int’ to ‘

Re: Review Request: Have ok/cancel buttons consistently at the bottom in dialogs, not the right side

2013-01-02 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108066/#review24478 --- This review has been submitted with commit df1334cfe2e9eb7fbf7

Re: Review Request: Have ok/cancel buttons consistently at the bottom in dialogs, not the right side

2013-01-02 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108066/#review24477 --- This review has been submitted with commit 1eabfe58896d41c1fd2

Re: Review Request: Have ok/cancel buttons consistently at the bottom in dialogs, not the right side

2013-01-02 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108066/#review24473 --- Ship it! Looks good. I see no problems for backporting to 2.6.

Re: Review Request: Have ok/cancel buttons consistently at the bottom in dialogs, not the right side

2013-01-02 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108066/ --- (Updated Jan. 2, 2013, 5:57 p.m.) Review request for Calligra and Marijn K

Re: Review Request: Have ok/cancel buttons consistently at the bottom in dialogs, not the right side

2013-01-02 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108066/ --- (Updated Jan. 2, 2013, 5:54 p.m.) Review request for Calligra and Marijn K

Re: Review Request: Have ok/cancel buttons consistently at the bottom in dialogs, not the right side

2013-01-02 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108066/#review24429 --- + the same note about Apply/Discard regarding the 'Footnotes/En

Re: Review Request: Have ok/cancel buttons consistently at the bottom in dialogs, not the right side

2013-01-02 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108066/#review24428 --- BTW, 'Configure bibliography' dialog uses Apply+Discard buttons

Re: Calligra Spring Sprint

2013-01-02 Thread Friedrich W. H. Kossebau
Happy new year, everybody! Am Dienstag, 11. Dezember 2012, 18:04:36 schrieb Inge Wallin: > On Wednesday, December 05, 2012 16:41:22 Inge Wallin wrote: > > Hi people, > > > > It's time to have another sprint! > > > > I have been in contact with the Linux hotel. They say that all weekends > > in

Re: Review Request: Make it possible to override info from author profile via dbus/c++

2013-01-02 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107486/#review24419 --- This review has been submitted with commit cbfd97a7a85c94d