Re: RR for removing 5 unused files from filters/sheets/csv

2012-12-30 Thread Jaroslaw Staniek
On 29 December 2012 23:16, Friedrich W. H. Kossebau wrote: > Hi, > > grepping for Q3 I found that these 5 files are no longer used. Seems it was > forgotten to remove them in the commit > 038515dfc447d0a3e2a6cfdd872efc67fcc1076d > Filters CSV Import. > Switch to the

Re: RR to remove filters/karbon/{applixgraphics,eps/EpsExport}

2012-12-30 Thread Boudewijn Rempt
On Sunday 30 December 2012 Dec, Friedrich W. H. Kossebau wrote: > Hi, > > some filters escaped the Great Filter Cleanup (tm) but now catched my > attention while grepping for Q3* classes. Having looked at them I propose to > move the following filters as well to the glory hole which there is git

RR to remove filters/karbon/{applixgraphics,eps/EpsExport}

2012-12-30 Thread Friedrich W. H. Kossebau
Hi, some filters escaped the Great Filter Cleanup (tm) but now catched my attention while grepping for Q3* classes. Having looked at them I propose to move the following filters as well to the glory hole which there is git history: filters/karbon/applixgraphics : not built ATM, also exports t

Review Request: spellchecking changes

2012-12-30 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108022/ --- Review request for Calligra. Description --- Change the way we draw m

Re: Review Request: Make the epub filter handle math formulas

2012-12-30 Thread C. Boemann
> On Dec. 28, 2012, 2:45 p.m., C. Boemann wrote: > > there is a few places where you have: > > > > if () > > { > > > > and one place where there is no {} after if > > > > other than that I've not looked yet - I assume you want moji to review > > Inge Wallin wrote: > The > > if (

Re: Review Request: Make the epub filter handle math formulas

2012-12-30 Thread Inge Wallin
> On Dec. 28, 2012, 2:45 p.m., C. Boemann wrote: > > there is a few places where you have: > > > > if () > > { > > > > and one place where there is no {} after if > > > > other than that I've not looked yet - I assume you want moji to review > > Inge Wallin wrote: > The > > if (

Re: Review Request: Fix sorting of style names

2012-12-30 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108020/#review24227 --- This review has been submitted with commit 7ea974af2415e3c4aa4

Re: Review Request: Fix sorting of style names

2012-12-30 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108020/#review24226 --- This review has been submitted with commit bec31b80838bfbad623

Re: Review Request: Fix sorting of style names

2012-12-30 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108020/#review24225 --- This review has been submitted with commit 36a0bd51606da126595

Re: Review Request: Fix sorting of style names

2012-12-30 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108020/#review24224 --- Ship it! yes please backport too great work - C. Boemann O

Review Request: Fix sorting of style names

2012-12-30 Thread Pierre Stirnweiss
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108020/ --- Review request for Calligra and C. Boemann. Description --- The style