Re: a new library

2012-12-18 Thread Thorsten Zachmann
Hello, On Wednesday 19 December 2012 01:55:38 C. Boemann wrote: > My suggestion is thus that we make a new library, which I call alpine as > it's a superstructure to flake. This alpine library will depend on > libs/widgets and contain basically tools, shapes and dockers that are too > important or

a new library

2012-12-18 Thread C. Boemann
Hi In an attempt to to rework the ui, we have run into a problem: KoCreatePathTool in libs/flake needs some widgets from libs/widgets however the dependency is in the opposite direction So unless we want to move the tools into libs/widgets we need to move the tool to somewhere else. It can't

Re: Review Request: Port KoProperty editors for Date, Time & DateTime to Qt4 and enable again

2012-12-18 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107792/#review23709 --- This review has been submitted with commit a9fbc6ee851cd27903d

Re: [calligra] /: Move the external library kdchart from the chart shape to 3rdparty/.

2012-12-18 Thread C. Boemann
On Tuesday 18 December 2012 23:04:31 Inge Wallin wrote: > On Tuesday, December 18, 2012 20:05:28 C. Boemann wrote: > > On Tuesday 18 December 2012 19:42:13 Thorsten Zachmann wrote: > > > On Tuesday 18 December 2012 19:29:39 Inge Wallin wrote: > > > > On Sunday, December 16, 2012 17:02:40 Inge Walli

Re: Review Request: Port KoProperty editors for Date, Time & DateTime to Qt4 and enable again

2012-12-18 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107792/#review23706 --- Ship it! Ship It! - Jarosław Staniek On Dec. 18, 2012, 12:0

Re: Review Request: Port KoProperty editors for Date, Time & DateTime to Qt4 and enable again

2012-12-18 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107792/#review23704 --- Good work! Okay to have the property options. I propose to ment

Re: [calligra] /: Move the external library kdchart from the chart shape to 3rdparty/.

2012-12-18 Thread Inge Wallin
On Tuesday, December 18, 2012 20:05:28 C. Boemann wrote: > On Tuesday 18 December 2012 19:42:13 Thorsten Zachmann wrote: > > On Tuesday 18 December 2012 19:29:39 Inge Wallin wrote: > > > On Sunday, December 16, 2012 17:02:40 Inge Wallin wrote: > > > > Git commit 3dbbc7afa43e548177eabea821ccdc18bd98

Re: Review Request: Remove usages of QString::null or resetting QStrings by = QString()

2012-12-18 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107807/#review23705 --- This review has been submitted with commit 82a44928e31596709dc

Re: Review Request: Remove usages of QString::null or resetting QStrings by = QString()

2012-12-18 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107807/#review23703 --- Ship it! Good catch, please fix the minor bits and push. fil

Review Request: Remove usages of QString::null or resetting QStrings by = QString()

2012-12-18 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107807/ --- Review request for Calligra. Description --- While I am pretty sure t

Re: [calligra] /: Move the external library kdchart from the chart shape to 3rdparty/.

2012-12-18 Thread Jaroslaw Staniek
On 18 December 2012 20:05, C. Boemann wrote: > On Tuesday 18 December 2012 19:42:13 Thorsten Zachmann wrote: >> On Tuesday 18 December 2012 19:29:39 Inge Wallin wrote: >> > On Sunday, December 16, 2012 17:02:40 Inge Wallin wrote: >> > > Git commit 3dbbc7afa43e548177eabea821ccdc18bd982566 by Inge W

Re: [calligra] /: Move the external library kdchart from the chart shape to 3rdparty/.

2012-12-18 Thread Thorsten Zachmann
On Tuesday 18 December 2012 20:05:28 C. Boemann wrote: > I wouldn't say we win nothing. The point of this change is to make it build > on windows. so how about creating a branch for windows if we want to have a backport of that? Thorsten ___ calligra-

Re: [calligra] /: Move the external library kdchart from the chart shape to 3rdparty/.

2012-12-18 Thread C. Boemann
On Tuesday 18 December 2012 19:42:13 Thorsten Zachmann wrote: > On Tuesday 18 December 2012 19:29:39 Inge Wallin wrote: > > On Sunday, December 16, 2012 17:02:40 Inge Wallin wrote: > > > Git commit 3dbbc7afa43e548177eabea821ccdc18bd982566 by Inge Wallin. > > > Committed on 16/12/2012 at 16:50. > >

Re: [calligra] /: Move the external library kdchart from the chart shape to 3rdparty/.

2012-12-18 Thread Thorsten Zachmann
On Tuesday 18 December 2012 19:29:39 Inge Wallin wrote: > On Sunday, December 16, 2012 17:02:40 Inge Wallin wrote: > > Git commit 3dbbc7afa43e548177eabea821ccdc18bd982566 by Inge Wallin. > > Committed on 16/12/2012 at 16:50. > > Pushed by ingwa into branch 'master'. > > > > Move the external libra

Re: [calligra] /: Move the external library kdchart from the chart shape to 3rdparty/.

2012-12-18 Thread Inge Wallin
On Sunday, December 16, 2012 17:02:40 Inge Wallin wrote: > Git commit 3dbbc7afa43e548177eabea821ccdc18bd982566 by Inge Wallin. > Committed on 16/12/2012 at 16:50. > Pushed by ingwa into branch 'master'. > > Move the external library kdchart from the chart shape to 3rdparty/. Ok to cherry-pick to

Review Request: Set cover image for ebooks in Author

2012-12-18 Thread mojtaba shahi
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107800/ --- Review request for Calligra. Description --- Add Book --> Insert Cove

Re: Review Request: Implement triple button widget

2012-12-18 Thread Jean-Nicolas Artaud
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107530/ --- (Updated Dec. 18, 2012, 2:46 p.m.) Review request for Calligra and C. Boem

Re: Review Request: Implement triple button widget

2012-12-18 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107530/#review23663 --- libs/widgets/KoGroupButton.h

Re: Review Request: Move the Create Path tool from flake/tools to plugins/defaulttools

2012-12-18 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107671/#review23662 --- Bah I was so hoping I could okay it now, but as krita needs it

Re: Review Request: Implement triple button widget

2012-12-18 Thread Jean-Nicolas Artaud
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107530/ --- (Updated Dec. 18, 2012, 10:08 a.m.) Review request for Calligra and C. Boe

Re: Review Request: Move the Create Path tool from flake/tools to plugins/defaulttools

2012-12-18 Thread Jean-Nicolas Artaud
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107671/ --- (Updated Dec. 18, 2012, 9:27 a.m.) Review request for Calligra. Changes

Re: Review Request: Implement triple button widget

2012-12-18 Thread Jarosław Staniek
> On Dec. 17, 2012, 2:34 p.m., Jean-Nicolas Artaud wrote: > > Hello Jeroslaw, > > Have you found some issues on this tripple button ? Maybe the name isn't > > okay cause you can group as many buttons as you need (so double, triple.. > > and multiple).. > > Thank you I am planning to test it,