Re: Review Request: import csv-file into existing table

2012-12-14 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107330/#review23494 --- Ship it! Ship It! - Jarosław Staniek On Dec. 13, 2012, 11:3

Re: Review Request: Show message when no database server drivers are found, when trying to create/open/import project.

2012-12-14 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107100/#review23492 --- Ship it! Ship It! - Jarosław Staniek On Nov. 21, 2012, 10:4

Re: Review Request: [GCI] Adding d-pointers to kexi/plugins

2012-12-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107672/#review23487 --- This review has been submitted with commit 3de63476d3ce2b088cd

Re: Review Request: [GCI] Adding d-pointers to kexi/formeditor

2012-12-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107647/#review23486 --- This review has been submitted with commit 3de63476d3ce2b088cd

Re: Review Request: [GCI] Adding d-pointers to kexi/main

2012-12-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107648/#review23489 --- This review has been submitted with commit 3de63476d3ce2b088cd

Re: Review Request: [GCI] Adding d-pointers to kexi/kexiutils

2012-12-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107649/#review23488 --- This review has been submitted with commit 3de63476d3ce2b088cd

Re: Review Request: Adds d-pointers to Kexi classes in kexi/core

2012-12-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107515/#review23484 --- This review has been submitted with commit 3de63476d3ce2b088cd

Re: Review Request: [GCI] Adding d-pointers to kexi/widget

2012-12-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107673/#review23485 --- This review has been submitted with commit 3de63476d3ce2b088cd

Re: Review Request: Move ElapsedTime class to a private header that wont be installed

2012-12-14 Thread Marijn Kruisselbrink
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107717/#review23471 --- Ship it! LGTM - Marijn Kruisselbrink On Dec. 14, 2012, 1:39

Re: Review Request: Move ElapsedTime class to a private header that wont be installed

2012-12-14 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107717/#review23460 --- Looks fine to me! Mek, what do you say? - Boudewijn Rempt On

Re: Reviewboard stripping the git header of patches. (Was: Re: Review Request: Move ElapsedTime class to a private header that wont be installed)

2012-12-14 Thread Boudewijn Rempt
On Friday 14 December 2012 Dec, Philip Van Hoof wrote: > Hi guys, > > What I don't really like about KDE's reviewboard is that git adds a > header to diffs when using git format-patch. And when the diff gets > applied by a reviewer to Calligra, then because this header is stripped > git doesn't al

Reviewboard stripping the git header of patches. (Was: Re: Review Request: Move ElapsedTime class to a private header that wont be installed)

2012-12-14 Thread Philip Van Hoof
Hi guys, What I don't really like about KDE's reviewboard is that git adds a header to diffs when using git format-patch. And when the diff gets applied by a reviewer to Calligra, then because this header is stripped git doesn't always recognize the patch having been applied with the commit in my

Review Request: Move ElapsedTime class to a private header that wont be installed

2012-12-14 Thread Philip Hoof
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107717/ --- Review request for Calligra. Description --- >From 6df02b31d66934ac57