Re: Review Request: [GCI] Adding d-pointers to kexi/formeditor

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107647/ --- (Updated Dec. 14, 2012, 7:40 a.m.) Review request for Calligra and Jarosła

Re: Review Request: [GCI] Adding d-pointers to kexi/formeditor

> On Dec. 13, 2012, 9:37 p.m., Jarosław Staniek wrote: > > kexi/formeditor/widgetfactory.h, line 355 > > > > > > move ALL these methods down to protected section > > Andrey Inishev wrote: > These methods alre

Re: Review Request: [GCI] Adding d-pointers to kexi/formeditor

> On Dec. 13, 2012, 9:37 p.m., Jarosław Staniek wrote: > > kexi/formeditor/widgetfactory.h, line 355 > > > > > > move ALL these methods down to protected section These methods already at protected section. Or you

Re: Review Request: import csv-file into existing table

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107330/ --- (Updated Dec. 13, 2012, 11:35 p.m.) Review request for Calligra, Jarosław

Re: Review Request: import csv-file into existing table

> On Nov. 25, 2012, 6:15 p.m., Jarosław Staniek wrote: > > "Fields count does not match" error is displayed on appending if the > > destination table is identical but contains extra primary-key column > > (generated by Kexi). I know this case is just not supported now. We would > > try to impo

Re: Review Request: [GCI] Adding d-pointers to kexi/kexiutils

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107649/#review23438 --- Ship it! Good job. I'll commit it for you when other tasks are

Re: Review Request: [GCI] Adding d-pointers to kexi/formeditor

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107647/#review23434 --- Almost ready! Please carefully fix the issues. kexi/formedito

Re: Compile errors while trying to build with Windows build of calligrasheetscommon

Ah, ok. Then ideally on Win32 should Calligra's CMakeList.txt add a dependency on kdewin, no? On Thu, 2012-12-13 at 12:48 -0800, Marijn Kruisselbrink wrote: > Old versions of MSVC did not include a definition of atanh (I'm not > sure if newer versions do, but at least MSVC 2012 seems to). When > b

Re: Compile errors while trying to build with Windows build of calligrasheetscommon

Old versions of MSVC did not include a definition of atanh (I'm not sure if newer versions do, but at least MSVC 2012 seems to). When building kde applications on windows, wrapper headers are used that make sure among others this symbol exist too (see https://projects.kde.org/projects/kdesupport/kd

Re: Review Request: Move the Create Path tool from flake/tools to plugins/defaulttools

> On Dec. 11, 2012, 10:35 p.m., C. Boemann wrote: > > plugins/defaultTools/createPathTool/KoCreatePathTool.cpp, line 373 > > > > > > To possible other reviewers. > > > > I said this was okay, we are going t

Re: Review Request: [GCI] Adding d-pointers to kexi/kexiutils

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107649/ --- (Updated Dec. 13, 2012, 12:06 p.m.) Review request for Calligra and Jarosł

Re: Review Request: [GCI] Adding d-pointers to kexi/plugins

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107672/ --- (Updated Dec. 13, 2012, 10:15 a.m.) Review request for Calligra and Jarosł

Re: Review Request: [GCI] Adding d-pointers to kexi/formeditor

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107647/ --- (Updated Dec. 13, 2012, 10:14 a.m.) Review request for Calligra and Jarosł

Compile errors while trying to build with Windows build of calligrasheetscommon

Hi there, I worked around these issues while building our application against Calligra's Sheets component: I could copy and paste assetfactory.cpp but it comes down to a include that ends up including Number.h. Not sure what that stuff with kglobal.h is, I just added a typedef for mode_t as a wor