Review Request: Fix use of deprecated kio api in braindump

2012-11-28 Thread Yue Liu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107508/ --- Review request for Calligra. Description --- Removed use of deprecate

-Wint-to-pointer-cast in plan

2012-11-28 Thread Jaroslaw Staniek
Hi, Are these safe warnings? /home/jarek/dev/src/calligra/plan/plugins/schedulers/tj/taskjuggler/Resource.cpp: In member function ‘bool TJ::Resource::bookSlot(uint, TJ::SbBooking*, int)’: /home/jarek/dev/src/calligra/plan/plugins/schedulers/tj/taskjuggler/Resource.cpp:500:40: warning: cast to poin

Review Request: Remove unneeded loop in KoDocumentRdf::emitSemanticObjectUpdated(...)

2012-11-28 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107506/ --- Review request for Calligra. Description --- The old code in KoDocume

Re: Review Request: Sort styles according to usage in the docker's combos

2012-11-28 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107445/#review22707 --- This review has been submitted with commit f3ae1099e25423e15a6

Re: Review Request: Make it possible to override info from author profile via dbus/c++

2012-11-28 Thread Pierre Stirnweiss
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107486/#review22704 --- Ship it! Minor point below. libs/main/KoDocumentInfo.h

Re: Review Request: Fix copy paste to include named styles

2012-11-28 Thread Inge Wallin
> On Nov. 28, 2012, 8:49 a.m., Inge Wallin wrote: > > The code looks good, I just had a couple of minor issues. What I wonder is > > if this is tested with LibreOffice and/or OpenOffice.org. Do we have > > interoperability? > > C. Boemann wrote: > I just tried and no there is no interpera

Re: Review Request: Sort styles according to usage in the docker's combos

2012-11-28 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107445/#review22688 --- Ship it! Great work - 2.7 will rock - C. Boemann On Nov. 27

Re: Review Request: Fix copy paste to include named styles

2012-11-28 Thread C. Boemann
> On Nov. 28, 2012, 8:49 a.m., Inge Wallin wrote: > > The code looks good, I just had a couple of minor issues. What I wonder is > > if this is tested with LibreOffice and/or OpenOffice.org. Do we have > > interoperability? I just tried and no there is no interperablity. Not sure it's such a

Re: Review Request: Fix copy paste to include named styles

2012-11-28 Thread Inge Wallin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107495/#review22682 --- The code looks good, I just had a couple of minor issues. What