Re: Architecture Refactor Suggestion: App-irrelevent Format Filters

2012-10-22 Thread Thorsten Zachmann
On Monday 22 October 2012 09:10:49 Inge Wallin wrote: > 2. That the filter uses Karbon internals in a way that it cannot be used by > Flow. This should be more a link issue than anything else, or am I wrong? That would make the filter for Flow depend on Karbon which people might find strange. An

Re: Architecture Refactor Suggestion: Bigger reorganization

2012-10-22 Thread Jaroslaw Staniek
On 22 October 2012 21:38, Inge Wallin wrote: > On Monday, October 22, 2012 20:49:05 Sven Langkamp wrote: >> On Mon, Oct 22, 2012 at 8:08 PM, Inge Wallin wrote: >> > On Monday, October 22, 2012 19:49:21 Sven Langkamp wrote: > > ... > >> > > I would prefer to have it at >> > > >> > > app/ >> > > >>

Re: Architecture Refactor Suggestion: Bigger reorganization

2012-10-22 Thread Inge Wallin
On Monday, October 22, 2012 20:49:05 Sven Langkamp wrote: > On Mon, Oct 22, 2012 at 8:08 PM, Inge Wallin wrote: > > On Monday, October 22, 2012 19:49:21 Sven Langkamp wrote: ... > > > I would prefer to have it at > > > > > > app/ > > > > > > core/ > > > uidesktop/ > > > uiactive/ >

Re: Architecture Refactor Suggestion: Bigger reorganization

2012-10-22 Thread Jaroslaw Staniek
On 22 October 2012 19:49, Sven Langkamp wrote: >> In the core/ directory the parts of the applications that are UI >> independent >> should reside. It should be basically loading, storage, saving (i.e. the >> document), painting, an API for data manipulation and all commands. >> >> All views unde

Re: Architecture Refactor Suggestion: Bigger reorganization

2012-10-22 Thread Sven Langkamp
On Mon, Oct 22, 2012 at 8:08 PM, Inge Wallin wrote: > On Monday, October 22, 2012 19:49:21 Sven Langkamp wrote: > > On Mon, Oct 22, 2012 at 9:30 AM, Inge Wallin > wrote: > > > On Sunday, October 21, 2012 18:11:18 Yue Liu wrote: > > > > 2012/10/21 Boudewijn Rempt : > > > > > On Sunday 21 October

Re: Architecture Refactor Suggestion: Bigger reorganization

2012-10-22 Thread Sven Langkamp
On Mon, Oct 22, 2012 at 3:04 PM, Inge Wallin wrote: > On Monday, October 22, 2012 09:57:51 Jaroslaw Staniek wrote: > > ... > > > That's good approach, especially the separation of painting routines > > from the headless part. > > No, I don't advocate separation of painting from the headless part.

Re: Architecture Refactor Suggestion: Bigger reorganization

2012-10-22 Thread Inge Wallin
On Monday, October 22, 2012 19:49:21 Sven Langkamp wrote: > On Mon, Oct 22, 2012 at 9:30 AM, Inge Wallin wrote: > > On Sunday, October 21, 2012 18:11:18 Yue Liu wrote: > > > 2012/10/21 Boudewijn Rempt : > > > > On Sunday 21 October 2012 Oct, Yue Liu wrote: > > > >> Hi, > > > >> > > > >> Currently

Re: Architecture Refactor Suggestion: Bigger reorganization

2012-10-22 Thread Sven Langkamp
On Mon, Oct 22, 2012 at 9:30 AM, Inge Wallin wrote: > On Sunday, October 21, 2012 18:11:18 Yue Liu wrote: > > 2012/10/21 Boudewijn Rempt : > > > On Sunday 21 October 2012 Oct, Yue Liu wrote: > > >> Hi, > > >> > > >> Currently filters are loaded based on application's native mime-type. > > >> And

Re: Review Request: Introduce KoTextRange instead of inline characters

2012-10-22 Thread Inge Wallin
On Monday, October 22, 2012 11:38:22 C. Boemann wrote: > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106983/ > --- > > Review req

Re: Architecture Refactor Suggestion: Bigger reorganization

2012-10-22 Thread Inge Wallin
On Monday, October 22, 2012 09:57:51 Jaroslaw Staniek wrote: ... > That's good approach, especially the separation of painting routines > from the headless part. No, I don't advocate separation of painting from the headless part. Paiting should be in the core. > Regarding the above hierarchy

Review Request: Introduce KoTextRange instead of inline characters

2012-10-22 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106983/ --- Review request for Calligra. Description --- Using inline characters

Re: Architecture Refactor Suggestion: Bigger reorganization

2012-10-22 Thread Boudewijn Rempt
On Monday 22 October 2012 Oct, Inge Wallin wrote: > I think we need to make a bigger reorganization. There are two things that > are > currently a problem: > > 1. The applications themselves have more than one UI, e.g. Calligra > Words/Sheets/Stage and Calligra Active. > > 2. Filters sometime

Re: Architecture Refactor Suggestion: Bigger reorganization

2012-10-22 Thread Jaroslaw Staniek
On 22 October 2012 09:30, Inge Wallin wrote: > On Sunday, October 21, 2012 18:11:18 Yue Liu wrote: >> 2012/10/21 Boudewijn Rempt : >> > On Sunday 21 October 2012 Oct, Yue Liu wrote: >> >> Hi, >> >> >> >> Currently filters are loaded based on application's native mime-type. >> >> And now we have mu

Re: Architecture Refactor Suggestion: Bigger reorganization

2012-10-22 Thread Inge Wallin
On Sunday, October 21, 2012 18:11:18 Yue Liu wrote: > 2012/10/21 Boudewijn Rempt : > > On Sunday 21 October 2012 Oct, Yue Liu wrote: > >> Hi, > >> > >> Currently filters are loaded based on application's native mime-type. > >> And now we have multiple applications with same native format, such as

Re: Architecture Refactor Suggestion: App-irrelevent Format Filters

2012-10-22 Thread Inge Wallin
On Sunday, October 21, 2012 06:56:49 Thorsten Zachmann wrote: > Hello, > > > Note: this is a problem for some Karbon filters, since they used > > KarbonPart to access shapes for shape painting. We can modify > > KoDocument::paintContent(painter, rect) to do that instead. > > it is not for paintin