Review Request: CSV Import: Import last line even if it is only ""

2012-08-09 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105950/ --- Review request for Calligra, Adam Pigg, Dimitrios Tanis, and Oleg Kukharchuk

Re: Review Request: CSV Import: Fix uniqueness detection for integer column

2012-08-09 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105949/ --- (Updated Aug. 9, 2012, 8:25 p.m.) Review request for Calligra, Adam Pigg,

Re: Review Request: CSV Import: Use KexiDB data types in implementation

2012-08-09 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105947/ --- (Updated Aug. 9, 2012, 8:20 p.m.) Review request for Calligra, Adam Pigg,

Review Request: CSV Import: Fix uniqueness detection for integer column

2012-08-09 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105949/ --- Review request for Calligra, Adam Pigg, Dimitrios Tanis, and Oleg Kukharchuk

Review Request: CSV Import: Use KexiDB data types in implementation

2012-08-09 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105947/ --- Review request for Calligra, Adam Pigg, Dimitrios Tanis, and Oleg Kukharchuk

Re: Review Request: Fix crash on importing CSV files with Mac line endings

2012-08-09 Thread Jarosław Staniek
> On Aug. 7, 2012, 6:18 p.m., Adam Pigg wrote: > > kexi/plugins/importexport/csv/kexicsvimportdialog.cpp, line 620 > > > > > > Should we be using QTextStream? I ask because we are trying to detect > > the type of

Re: Review Request: Fix crash on importing CSV files with more than 1024 columns

2012-08-09 Thread Adam Pigg
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105844/#review17165 --- Ship it! Ship It! - Adam Pigg On Aug. 9, 2012, 1:35 p.m., J

Re: Review Request: Fix crash on importing CSV files with Mac line endings

2012-08-09 Thread Adam Pigg
> On Aug. 7, 2012, 6:18 p.m., Adam Pigg wrote: > > kexi/plugins/importexport/csv/kexicsvimportdialog.cpp, line 620 > > > > > > Should we be using QTextStream? I ask because we are trying to detect > > the type of

Re: Review Request: Fix crash on importing CSV files with Mac line endings

2012-08-09 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105843/ --- (Updated Aug. 9, 2012, 1:35 p.m.) Review request for Calligra, Adam Pigg,

Re: Review Request: Fix crash on importing CSV files with more than 1024 columns

2012-08-09 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105844/ --- (Updated Aug. 9, 2012, 1:35 p.m.) Review request for Calligra, Adam Pigg,

Re: Review Request: Display cmake warning if libpqxx is not in version 3.x

2012-08-09 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105874/ --- (Updated Aug. 9, 2012, 1:35 p.m.) Review request for Calligra, Adam Pigg,